fix: stop returning EINVAL on remount of detached mounts

shanduur · shanduur · commit fe36b3d3200d · 2025-09-30T16:21:58.000+02:00
When `RemountReadOnly` was called on a detached mount, it returned `EINVAL`.
This is not the expected behavior.

Signed-off-by: Mateusz Urbanek &lt;mateusz.urbanek@siderolabs.com&gt;
diff --git a/internal/pkg/mount/v3/point.go b/internal/pkg/mount/v3/point.go
@@ -259,7 +259,7 @@ func (p *Point) Root() xfs.Root {
 // RemountReadOnly remounts the mount point as read-only.
 func (p *Point) RemountReadOnly() error {
 	if p.detached {
-		return syscall.EINVAL
+		return nil
 	}
 
 	return p.setattr(&unix.MountAttr{

Original file line number	Diff line number	Diff line change
`@@ -259,7 +259,7 @@ func (p *Point) Root() xfs.Root {`
`259`	`259`	`// RemountReadOnly remounts the mount point as read-only.`
`260`	`260`	`func (p *Point) RemountReadOnly() error {`
`261`	`261`	`if p.detached {`
`262`		`- return syscall.EINVAL`
	`262`	`+ return nil`
`263`	`263`	`}`
`264`	`264`
`265`	`265`	`return p.setattr(&unix.MountAttr{`