Include raw subject in certificates

Sometimes identities have a different identifier that isn't captured by existing certificates, usually
because the identifier isn't useful as a human friendly reference. For example - GCP accounts have
an opaque numerical identifier.

That said, subject is particularly useful to preserve since OIDC spec requires
(issuer, subject) to be the canonical representation for an identity, and sometimes
these opaque identifiers can be difficult to otherwise resolve.

This change preserves the incoming subject as-is. While this may result in some duplicative
data for some providers, this helps give a consistent reference point across OIDC issuers.

Signed-off-by: Billy Lynch <billy@chainguard.dev>

Author: wlynch

docs/oid-info.md

@@ -52,7 +52,7 @@ Nice-to-haves:
 
 `1.3.6.1.4.1.57264.1.7` is formatted as a DER-encoded string in the SubjectAlternativeName extension, as per RFC 5280 4.2.1.6.
 
-`1.3.6.1.4.1.57264.1.8` through `1.3.6.1.4.1.57264.1.22` are formatted as DER-encoded strings; the ASN.1 tag is
+`1.3.6.1.4.1.57264.1.8` through `1.3.6.1.4.1.57264.1.24` are formatted as DER-encoded strings; the ASN.1 tag is
 UTF8String (0x0C) and the tag class is universal.
 
 ## Directory
@@ -186,6 +186,10 @@ Source repository visibility at the time of signing the certificate. MAY be empt
 
 Deployment target for a given job that maps to deployment protection rules. May be empty if no environment is defined. For example: `production` or `staging`.
 
+### 1.3.6.1.4.1.57264.1.24 | Token Subject
+
+The raw `sub` claim from the OIDC ID token that was presented at the time the code signing certificate was requested. This preserves the original token subject as-is, regardless of how the provider maps it to certificate SANs or other extensions. For example: `repo:sigstore/fulcio:ref:refs/heads/main` for GitHub Actions, or `project_path:mygroup/myproject:ref_type:branch:ref:main` for GitLab.
+
 ## 1.3.6.1.4.1.57264.2 | Policy OID for Sigstore Timestamp Authority
 
 Not used by Fulcio. This specifies the policy OID for the [timestamp authority](https://github.com/sigstore/timestamp-authority)
@@ -215,6 +219,7 @@ that Sigstore operates.
 | server_url + repository + "/actions/runs/" + run_id + "/attempts/" + run_attempt | server_url + project_path + "/-/jobs/" + job_id                                                   | server_url + "/" organization_slug + "/" + pipeline_slug + "/builds/" + build_number + "#" + job_id | platform_url + "/build/" + workflow_id                                          | platform_url + "/workflow/" + workflow-id + "/job/" + job-id                                                                       | Run Invocation URI                      | An immutable identifier that can uniquely identify the build execution                                                                                                                 |
 | repository_visibility                                                            | project_visibility                                                                                | N/A                                                                                                 | N/A                                                                             | N/A                                                                                                                                | Source Repository Visibility At Signing | Source repository visibility at the time of signing the certificate                                                                                                                    |
 | environment                                                                      | environment                                                                                       | N/A                                                                                                 | N/A                                                                             | N/A                                                                                                                                | Deployment Environment                  | Deployment target for a workflow or job                                                                                                                                                |
+| sub                                                                              | sub                                                                                               | sub                                                                                                 | sub                                                                             | sub                                                                                                                                | Token Subject                           | The raw `sub` claim from the OIDC ID token                                                                                                                                             |
 
 [github-oidc-doc]: https://docs.github.com/en/actions/reference/security/oidc#oidc-token-claims
 [oid-link]: http://oid-info.com/get/1.3.6.1.4.1.57264

pkg/certificate/extensions.go

@@ -35,8 +35,9 @@ var (
 	// Deprecated: Use OIDSourceRepositoryRef
 	OIDGitHubWorkflowRef = asn1.ObjectIdentifier{1, 3, 6, 1, 4, 1, 57264, 1, 6}
 
-	OIDOtherName = asn1.ObjectIdentifier{1, 3, 6, 1, 4, 1, 57264, 1, 7}
-	OIDIssuerV2  = asn1.ObjectIdentifier{1, 3, 6, 1, 4, 1, 57264, 1, 8}
+	OIDOtherName    = asn1.ObjectIdentifier{1, 3, 6, 1, 4, 1, 57264, 1, 7}
+	OIDIssuerV2     = asn1.ObjectIdentifier{1, 3, 6, 1, 4, 1, 57264, 1, 8}
+	OIDTokenSubject = asn1.ObjectIdentifier{1, 3, 6, 1, 4, 1, 57264, 1, 24}
 
 	// CI extensions
 	OIDBuildSignerURI                      = asn1.ObjectIdentifier{1, 3, 6, 1, 4, 1, 57264, 1, 9}
@@ -136,6 +137,9 @@ type Extensions struct {
 
 	// Deployment target for a workflow or job
 	DeploymentEnvironment string `json:"DeploymentEnvironment,omitempty" yaml:"deployment-environment,omitempty"` // 1.3.6.1.4.1.57264.1.23
+
+	// Raw OIDC token subject (`sub` claim).
+	Subject string `json:"Subject,omitempty" yaml:"subject,omitempty"` // 1.3.6.1.4.1.57264.1.24
 }
 
 func (e Extensions) Render() ([]pkix.Extension, error) {
@@ -348,6 +352,16 @@ func (e Extensions) Render() ([]pkix.Extension, error) {
 			Value: val,
 		})
 	}
+	if e.Subject != "" {
+		val, err := asn1.MarshalWithParams(e.Subject, "utf8")
+		if err != nil {
+			return nil, err
+		}
+		exts = append(exts, pkix.Extension{
+			Id:    OIDTokenSubject,
+			Value: val,
+		})
+	}
 
 	return exts, nil
 }
@@ -435,6 +449,10 @@ func ParseExtensions(ext []pkix.Extension) (Extensions, error) {
 			if err := ParseDERString(e.Value, &out.DeploymentEnvironment); err != nil {
 				return Extensions{}, err
 			}
+		case e.Id.Equal(OIDTokenSubject):
+			if err := ParseDERString(e.Value, &out.Subject); err != nil {
+				return Extensions{}, err
+			}
 		}
 	}
 

pkg/certificate/extensions_test.go

@@ -58,6 +58,7 @@ func TestExtensions(t *testing.T) {
 				RunInvocationURI:                    "21",     // 1.3.6.1.4.1.57264.1.21
 				SourceRepositoryVisibilityAtSigning: "22",     // 1.3.6.1.4.1.57264.1.22
 				DeploymentEnvironment:               "23",     // 1.3.6.1.4.1.57264.1.23
+				Subject:                             "24",     // 1.3.6.1.4.1.57264.1.24
 			},
 			Expect: []pkix.Extension{
 				{
@@ -148,6 +149,10 @@ func TestExtensions(t *testing.T) {
 					Id:    OIDDeploymentEnvironment,
 					Value: marshalDERString(t, "23"),
 				},
+				{
+					Id:    OIDTokenSubject,
+					Value: marshalDERString(t, "24"),
+				},
 			},
 			WantErr: false,
 		},

pkg/identity/buildkite/principal.go

@@ -80,7 +80,8 @@ func (p jobPrincipal) Embed(_ context.Context, cert *x509.Certificate) error {
 
 	// Embed additional information into custom extensions
 	cert.ExtraExtensions, err = certificate.Extensions{
-		Issuer: p.issuer,
+		Issuer:  p.issuer,
+		Subject: p.subject,
 	}.Render()
 	if err != nil {
 		return err

pkg/identity/chainguard/principal.go

@@ -80,7 +80,8 @@ func (w workflowPrincipal) Embed(_ context.Context, cert *x509.Certificate) erro
 	cert.URIs = []*url.URL{baseURL.JoinPath(w.subject)}
 
 	cert.ExtraExtensions, err = certificate.Extensions{
-		Issuer: w.issuer,
+		Issuer:  w.issuer,
+		Subject: w.subject,
 
 		// TODO(mattmoor): Embed more of the Chainguard token structure via OIDs.
 	}.Render()

pkg/identity/ciprovider/principal.go

@@ -168,7 +168,7 @@ func (principal ciPrincipal) Embed(_ context.Context, cert *x509.Certificate) er
 		s := v.Field(i).String() // value of each field, e.g the template string
 		// We check the field name to avoid applying the template for the Issuer.
 		// The Issuer field should always come from the token issuer.
-		if strings.TrimSpace(s) == "" || vType.Field(i).Name == "Issuer" {
+		if strings.TrimSpace(s) == "" || vType.Field(i).Name == "Issuer" || vType.Field(i).Name == "Subject" {
 			continue
 		}
 		extValue, err := applyTemplateOrReplace(s, claims, defaults,
@@ -182,9 +182,10 @@ func (principal ciPrincipal) Embed(_ context.Context, cert *x509.Certificate) er
 		v.Field(i).SetString(extValue)
 	}
 
-	// Guarantee that the extension issuer is set to the token issuer,
-	// regardless of whether this field has been set before
+	// Guarantee that the extension issuer and subject are set to the token values,
+	// regardless of whether these fields have been set before
 	claimsTemplates.Issuer = principal.Token.Issuer
+	claimsTemplates.Subject = principal.Token.Subject
 	// Embed additional information into custom extensions
 	cert.ExtraExtensions, err = claimsTemplates.Render()
 	if err != nil {

pkg/identity/codefresh/principal.go

@@ -150,7 +150,8 @@ func (w workflowPrincipal) Embed(_ context.Context, cert *x509.Certificate) erro
 	cert.URIs = []*url.URL{baseURL.JoinPath(w.accountName, fmt.Sprintf("%s:%s/%s", w.pipelineName, w.accountID, w.pipelineID))}
 
 	cert.ExtraExtensions, err = certificate.Extensions{
-		Issuer: w.issuer,
+		Issuer:  w.issuer,
+		Subject: w.subject,
 		// URL of the build in Codefresh.
 		// The workflow url is used for build signer in Codefresh because for public builds unauthenticated users only have access to the workflow, not the pipeline definition.
 		// Also, the workflow contains the definition of the pipeline that was used at the time of the build, making it ideal to be used as the signer url.

pkg/identity/email/principal.go

@@ -31,6 +31,7 @@ import (
 type principal struct {
 	address string
 	issuer  string
+	subject string
 }
 
 func PrincipalFromIDToken(ctx context.Context, token *oidc.IDToken) (identity.Principal, error) {
@@ -61,6 +62,7 @@ func PrincipalFromIDToken(ctx context.Context, token *oidc.IDToken) (identity.Pr
 	return principal{
 		issuer:  issuer,
 		address: emailAddress,
+		subject: token.Subject,
 	}, nil
 }
 
@@ -73,7 +75,8 @@ func (p principal) Embed(_ context.Context, cert *x509.Certificate) error {
 
 	var err error
 	cert.ExtraExtensions, err = certificate.Extensions{
-		Issuer: p.issuer,
+		Issuer:  p.issuer,
+		Subject: p.subject,
 	}.Render()
 	if err != nil {
 		return err

pkg/identity/email/principal_test.go

@@ -57,6 +57,7 @@ func TestPrincipalFromIDToken(t *testing.T) {
 			ExpectedPrincipal: principal{
 				issuer:  "https://iss.example.com",
 				address: "alice@example.com",
+				subject: "doesntmatter",
 			},
 			WantErr: false,
 		},
@@ -84,6 +85,7 @@ func TestPrincipalFromIDToken(t *testing.T) {
 			ExpectedPrincipal: principal{
 				issuer:  "https://example.com",
 				address: "alice@example.com",
+				subject: "doesntmatter",
 			},
 			WantErr: false,
 		},
@@ -111,6 +113,7 @@ func TestPrincipalFromIDToken(t *testing.T) {
 			ExpectedPrincipal: principal{
 				issuer:  "https://example.com",
 				address: "alice@example.com",
+				subject: "doesntmatter",
 			},
 			WantErr: false,
 		},
@@ -173,6 +176,7 @@ func TestPrincipalFromIDToken(t *testing.T) {
 			ExpectedPrincipal: principal{
 				issuer:  "https://internal.example.com",
 				address: "alice@example.com",
+				subject: "doesntmatter",
 			},
 			WantErr: false,
 		},
@@ -197,6 +201,7 @@ func TestPrincipalFromIDToken(t *testing.T) {
 			ExpectedPrincipal: principal{
 				issuer:  "https://internal.example.com",
 				address: "alice@example.com",
+				subject: "doesntmatter",
 			},
 			WantErr: false,
 		},
@@ -221,6 +226,7 @@ func TestPrincipalFromIDToken(t *testing.T) {
 			ExpectedPrincipal: principal{
 				issuer:  "https://internal.example.com",
 				address: "alice@example.com",
+				subject: "doesntmatter",
 			},
 			WantErr: false,
 		},

pkg/identity/github/principal.go

@@ -199,7 +199,8 @@ func (w workflowPrincipal) Embed(_ context.Context, cert *x509.Certificate) erro
 
 	// Embed additional information into custom extensions
 	cert.ExtraExtensions, err = certificate.Extensions{
-		Issuer: w.issuer,
+		Issuer:  w.issuer,
+		Subject: w.subject,
 		// BEGIN: Deprecated
 		GithubWorkflowTrigger:    w.eventName,
 		GithubWorkflowSHA:        w.sha,