Skip to content

Commit 603cc15

Browse files
committed
Code review comments
Signed-off-by: Priya Wadhwa <priya@chainguard.dev>
1 parent 5953a16 commit 603cc15

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,3 @@ rekorServerImagerefs
1717
rekorCliImagerefs
1818
trillianServerImagerefs
1919
trillianSignerImagerefs
20-
logs

tests/rekor-harness.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function build_cli () {
5050
cli_version=$1
5151
current_branch=$(git rev-parse --abbrev-ref HEAD)
5252
git checkout $cli_version
53-
go build -o rekor-cli ./cmd/rekor-cli
53+
make rekor-cli
5454
git checkout $current_branch
5555
}
5656

@@ -63,8 +63,8 @@ function run_tests () {
6363
go clean -testcache
6464
for test in $HARNESS_TESTS
6565
do
66-
if ! REKORTMPDIR=$REKORTMPDIR go test -run $test -v -tags=e2e ./tests/ > logs ; then
67-
cat logs
66+
if ! REKORTMPDIR=$REKORTMPDIR go test -run $test -v -tags=e2e ./tests/ > $REKORTMPDIR/logs ; then
67+
cat $REKORTMPDIR/logs
6868
docker-compose logs --no-color > /tmp/docker-compose.log
6969
exit 1
7070
fi

0 commit comments

Comments
 (0)