Fixing Cacti#5185 - Orphaned Poller Items

Repair Database does not prune old Poller Item Records

Author: TheWitness

CHANGELOG

@@ -27,6 +27,7 @@ Cacti CHANGELOG
 -issue#5181: Poller functions can cause SQL errors in some cases when working with remote data collectors
 -issue#5182: Graph Image does not have check for Remote Agent
 -issue#5184: Cacti permission checks generate SQL errors is the user has been deleted
+-issue#5185: Repair Database does not prune old Poller Item Records
 
 1.2.23
 -security#4920: Add .htaccess file to scripts folder

cli/repair_database.php

@@ -255,6 +255,21 @@
 	print 'NOTE: Found No Data Input Data hostname or host_id Type Code issues' . PHP_EOL;
 }
 
+print 'NOTE: Repairing orphaned Poller Items.' . PHP_EOL;
+
+db_execute('DELETE pi
+	FROM poller_item AS pi
+	LEFT JOIN data_local AS dl
+	ON pi.local_data_id = dl.id
+	WHERE dl.id IS NULL');
+
+$fixes = db_affected_rows();
+if ($fixes) {
+	printf('NOTE: Found and Repaired %s Poller Items' . PHP_EOL, $fixes);
+} else {
+	print 'NOTE: Found No Problems with orphaned Poller Items' . PHP_EOL;
+}
+
 print PHP_EOL . '------------------------------------------------------------------------' . PHP_EOL;
 print 'Detailed Checks.  Use --force to repair if found.' . PHP_EOL . PHP_EOL;