change the name of the identifying attribute parameter

Author: restena-sw

README.md

@@ -35,6 +35,9 @@ ALTER TABLE credentials ADD COLUMN `hashedId` VARCHAR(100) DEFAULT '---' AFTER `
 The updated schema is compatible with the 0.11.x releases, so a roll-back to an
 older version is still possible without removing the column.
 
+Also note that the parameter attribute_username was changed to identifyingAttribute
+to achieve better consistency with other authproc filters.
+
 How to setup the webauthn module as an authprocfilter
 -----------------------------------------------------
 You need to enable the module's authprocfilter at a priority level

config-templates/module_webauthn.php

@@ -12,7 +12,7 @@
         'database.password' => 'sdfsdf',
     ],
 
-    'attrib_username' => 'urn:oid:1.3.6.1.4.1.23735.100.0',
+    'identifyingAttribute' => 'uid',
     'attrib_displayname' => 'urn:oid:2.5.4.3',
 
     /* FIDO2 is phishing-resistent by binding generated credentials to a scope.

src/Controller/Registration.php

@@ -139,7 +139,7 @@ public function main(/** @scrutinizer ignore-unused */ Request $request): Runnab
         if ($hostname !== null) {
             $stateData->derivedScope = $hostname;
         }
-        $stateData->usernameAttrib = $moduleConfig->getString('attrib_username');
+        $stateData->usernameAttrib = $moduleConfig->getString('identifyingAttribute');
         $stateData->displaynameAttrib = $moduleConfig->getString('attrib_displayname');
 
         StaticProcessHelper::prepareState($stateData, $state);

src/Controller/WebAuthn.php

@@ -131,10 +131,10 @@ public static function loadModuleConfig($moduleConfig, &$stateData): void {
             $stateData->derivedScope = $hostname;
         }
 
-        if (array_key_exists('attrib_username', $moduleConfig)) {
-            $stateData->usernameAttrib = $moduleConfig['attrib_username'];
+        if (array_key_exists('identifyingAttribute', $moduleConfig)) {
+            $stateData->usernameAttrib = $moduleConfig['identifyingAttribute'];
         } else {
-            throw new Error\CriticalConfigurationError('webauthn: it is required to set attrib_username in config.');
+            throw new Error\CriticalConfigurationError('webauthn: it is required to set identifyingAttribute in config.');
         }
 
         if (array_key_exists('attrib_displayname', $moduleConfig)) {

tests/src/Controller/RegistrationTest.php

@@ -53,7 +53,7 @@ protected function setUp(): void
         Configuration::setPreLoadedConfig(
             Configuration::loadFromArray(
                 [
-                    'attrib_username' => 'uid',
+                    'identifyingAttribute' => 'uid',
                     'attrib_displayname' => 'displayName',
                     'store' => [
                         'webauthn:Database',