Make tests run on non-English Windows (#110)

Author: Septh

test/helpers/assert.js

@@ -1,3 +1,4 @@
+import {spawnSync} from 'node:child_process';
 import {nonExistentCommand, nodeHangingCommand, nodeEvalCommandStart} from './commands.js';
 
 export const assertSubprocessErrorName = (t, name) => {
@@ -23,13 +24,24 @@ export const assertNonExistent = (t, {name, exitCode, signalName, command, messa
 	assertDurationMs(t, durationMs);
 };
 
+// Support localized error messages on non-English Windows.
+let nonExistentCommandOutput;
+const toNonExistentCommandOutput = command => {
+	if (typeof nonExistentCommandOutput !== 'string') {
+		const {stderr} = spawnSync(nonExistentCommand, {shell: true, encoding: 'utf8'});
+		nonExistentCommandOutput = stderr.replace(/\r?\n$/, '');
+	}
+
+	return nonExistentCommandOutput.replaceAll(nonExistentCommand, command.split(/[ /]/)[0]);
+};
+
 export const assertWindowsNonExistent = (t, {name, exitCode, signalName, command, message, stderr, cause, durationMs}, expectedCommand = nonExistentCommand) => {
 	assertSubprocessErrorName(t, name);
 	t.is(exitCode, 1);
 	t.is(signalName, undefined);
 	t.is(command, expectedCommand);
 	t.is(message, `Command failed with exit code 1: ${expectedCommand}`);
-	t.true(stderr.includes('not recognized as an internal or external command'));
+	t.is(stderr, toNonExistentCommandOutput(expectedCommand));
 	t.is(cause, undefined);
 	assertDurationMs(t, durationMs);
 };

test/helpers/setup.js

@@ -12,16 +12,17 @@ const updateCodePage = codePage => {
 	assert(getCodePage() === codePage);
 };
 
-// On Windows in simplified chinese, the default code page is 936
-// Run `chcp 65001` to change it to UTF8
+// On Windows, run `chcp 65001` to change the current code page to UTF8.
+// This is necessary to correctly parse non-English cmd.exe error output.
 // https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp
+// and https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers
 export default function setup() {
 	if (process.platform !== 'win32') {
 		return;
 	}
 
 	const originalCodePage = getCodePage();
-	if (originalCodePage === '936') {
+	if (originalCodePage !== '65001') {
 		updateCodePage('65001');
 
 		process.on('exit', () => {