SharedUnionFieldsDeep: Fix support for optional fields (#988)

Author: Emiyaaaaa

source/shared-union-fields-deep.d.ts

@@ -98,13 +98,18 @@ export type SharedUnionFieldsDeep<Union, Options extends SharedUnionFieldsDeepOp
 Same as `SharedUnionFieldsDeep`, but accepts only `object`s and as inputs. Internal helper for `SharedUnionFieldsDeep`.
 */
 type SharedObjectUnionFieldsDeep<Union, Options extends SharedUnionFieldsDeepOptions> =
+	// `keyof Union` can extract the same key in union type, if there is no same key, return never.
 	keyof Union extends infer Keys
 		? IsNever<Keys> extends false
 			? {
 				[Key in keyof Union]:
 				Union[Key] extends NonRecursiveType
 					? Union[Key]
-					: SharedUnionFieldsDeep<Union[Key], Options>
+					// Remove `undefined` from the union to support optional
+					// fields, then recover `undefined` if union was already undefined.
+					: SharedUnionFieldsDeep<Exclude<Union[Key], undefined>, Options> | (
+						undefined extends Required<Union>[Key] ? undefined : never
+					)
 			}
 			: {}
 		: Union;

test-d/shared-union-fields-deep.ts

@@ -132,3 +132,14 @@ expectType<TestingType>(same);
 // Test for propagation with non union root object
 declare const nonUnionRootType: SharedUnionFieldsDeep<{union: {number: number; boolean: boolean} | {number: number}}>;
 expectType<{union: {number: number}}>(nonUnionRootType);
+
+declare const unionWithUndefined: SharedUnionFieldsDeep<{
+	a?: {a: string; foo: number} | {a: string; bar: string} | undefined;
+	b?: {a: string; foo: number} | {a: string; bar: string};
+	c: {a: string; foo: number} | {a: string; bar: string} | undefined;
+}>;
+expectType<{
+	a?: {a: string} | undefined;
+	b?: {a: string};
+	c: {a: string} | undefined;
+}>(unionWithUndefined);