Added sfl::dtl::is_trivially_copyable

Author: slavenf

include/sfl/detail/bit/bit_cast.hpp

@@ -21,10 +21,10 @@
 #ifndef SFL_DETAIL_BIT_CAST_HPP_INCLUDED
 #define SFL_DETAIL_BIT_CAST_HPP_INCLUDED
 
+#include <sfl/detail/type_traits/is_trivially_copyable.hpp>
 #include <sfl/detail/cpp.hpp>
 
 #include <cstring> // memcpy
-#include <type_traits> // is_trivially_copyable
 
 #if SFL_CPP_VERSION >= SFL_CPP_20
 #include <bit> // bit_cast
@@ -46,13 +46,8 @@ template <class To, class From>
 To bit_cast_impl_11(const From& src) noexcept
 {
     static_assert(sizeof(To) == sizeof(From), "To and From must have the same size");
-    #if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ < 5)) || (defined(__clang__) && (__clang_major__ < 4))
-    static_assert(__has_trivial_copy(From), "From must be trivially copyable");
-    static_assert(__has_trivial_copy(To), "To must be trivially copyable");
-    #else
-    static_assert(std::is_trivially_copyable<From>::value, "From must be trivially copyable");
-    static_assert(std::is_trivially_copyable<To>::value, "To must be trivially copyable");
-    #endif
+    static_assert(sfl::dtl::is_trivially_copyable<From>::value, "From must be trivially copyable");
+    static_assert(sfl::dtl::is_trivially_copyable<To>::value, "To must be trivially copyable");
 
     To dst;
     std::memcpy(&dst, &src, sizeof(To));

include/sfl/detail/type_traits/is_trivially_copyable.hpp

@@ -0,0 +1,45 @@
+//
+// Copyright (c) 2022 Slaven Falandys
+//
+// This software is provided 'as-is', without any express or implied
+// warranty. In no event will the authors be held liable for any damages
+// arising from the use of this software.
+//
+// Permission is granted to anyone to use this software for any purpose,
+// including commercial applications, and to alter it and redistribute it
+// freely, subject to the following restrictions:
+//
+// 1. The origin of this software must not be misrepresented; you must not
+//    claim that you wrote the original software. If you use this software
+//    in a product, an acknowledgment in the product documentation would be
+//    appreciated but is not required.
+// 2. Altered source versions must be plainly marked as such, and must not be
+//    misrepresented as being the original software.
+// 3. This notice may not be removed or altered from any source distribution.
+//
+
+#ifndef SFL_DETAIL_IS_TRIVIALLY_COPYABLE_HPP_INCLUDED
+#define SFL_DETAIL_IS_TRIVIALLY_COPYABLE_HPP_INCLUDED
+
+#include <type_traits> // is_trivially_copyable, integral_constant
+
+namespace sfl
+{
+
+namespace dtl
+{
+
+template <typename T>
+struct is_trivially_copyable
+    #if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ < 5)) || (defined(__clang__) && (__clang_major__ < 4))
+    : std::integral_constant<bool, __has_trivial_copy(T)>
+    #else
+    : std::is_trivially_copyable<T>
+    #endif
+{};
+
+} // namespace dtl
+
+} // namespace sfl
+
+#endif // SFL_DETAIL_IS_TRIVIALLY_COPYABLE_HPP_INCLUDED

test/src/normal_iterator/normal_iterator.cpp

@@ -2,25 +2,17 @@
 
 #include "sfl/detail/normal_iterator.hpp"
 
+#include "sfl/detail/type_traits/is_trivially_copyable.hpp"
+
 #include <type_traits>
 
 using iterator = sfl::dtl::normal_iterator<int*, false>;
 
 using const_iterator = sfl::dtl::normal_iterator<int*, true>;
 
-#if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ < 5)) || (defined(__clang__) && (__clang_major__ < 4))
-
-static_assert(__has_trivial_copy(iterator), "");
-
-static_assert(__has_trivial_copy(const_iterator), "");
-
-#else
-
-static_assert(std::is_trivially_copyable<iterator>::value, "");
-
-static_assert(std::is_trivially_copyable<const_iterator>::value, "");
+static_assert(sfl::dtl::is_trivially_copyable<iterator>::value, "");
 
-#endif
+static_assert(sfl::dtl::is_trivially_copyable<const_iterator>::value, "");
 
 static_assert(std::is_same<typename iterator::pointer, int*>::value, "");
 

test/src/static_storage/static_storage.cpp

@@ -2,6 +2,8 @@
 
 #include "sfl/detail/static_storage.hpp"
 
+#include "sfl/detail/type_traits/is_trivially_copyable.hpp"
+
 #include "check.hpp"
 
 #include <iterator>
@@ -14,19 +16,9 @@ using pointer = typename static_storage::pointer;
 
 using const_pointer = typename static_storage::const_pointer;
 
-#if (defined(__GNUC__) && !defined(__clang__) && (__GNUC__ < 5)) || (defined(__clang__) && (__clang_major__ < 4))
-
-static_assert(__has_trivial_copy(pointer), "");
-
-static_assert(__has_trivial_copy(const_pointer), "");
-
-#else
-
-static_assert(std::is_trivially_copyable<pointer>::value, "");
-
-static_assert(std::is_trivially_copyable<const_pointer>::value, "");
+static_assert(sfl::dtl::is_trivially_copyable<pointer>::value, "");
 
-#endif
+static_assert(sfl::dtl::is_trivially_copyable<const_pointer>::value, "");
 
 static_assert(std::is_same<typename std::pointer_traits<pointer>::element_type, int>::value, "");