From 1a7ab3f2c6c349b43f6a674f0347ab1f8f9658cb Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 18 May 2026 22:33:40 +0000
Subject: [PATCH 1/2] feat(ui): D.2 migrate SamplePlayback to ui/ primitives
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR 3 of 16 in the UI consistency overhaul. Worst-drift fix: kills
every raw zinc-* / amber-* / emerald-* / rounded-lg instance in
SamplePlayback.tsx (was 13 occurrences, now 0).

Stacked on top of PR #65 (D.1 primitives). Will be rebased onto main
once PR #65 merges.

Migration:
- Outer <section> → <DeviceRack name="AUDITION SAMPLES"
  subtitle="· Phase 3 heuristic" status={rackStatusFor(...)}>. Rack
  status reflects panel state — error tone on failure, active tone
  while generating, success tone once a manifest is rendered.
- Original <h3> id-based labelling replaced by aria-label on the
  DeviceRack; the title strip carries the visible name.
- Regenerate <button> → <Button variant="link" size="sm"> in the
  title-strip action slot.
- Generate <button> → <Button variant="primary" size="md"
  ledIndicator> in the body.
- ManifestMeta pill spans → <Pill tone="neutral" leadingDot>.
- SampleGroup <h4> → <SectionHeader size="sm" eyebrow="Group"
  title={CATEGORY_LABELS[category]}>.
- SampleCard <li> rounded-md border → <Panel variant="surface"
  padding="md"> (wrapped in a <li> for list semantics).
- confidenceClassFor() className helper → confidenceTone() returning
  a Pill tone (warning for LOW / low-confidence, neutral for MED,
  success for HIGH).
- Code spans for cited Phase 1 field paths now use design-token
  colors (bg-bg-app, border-border, text-text-primary) instead of
  raw zinc-300/zinc-800.
- MIDI download link uses text-accent + underline instead of zinc.

No behavior changes — same callbacks, same conditional rendering, same
content. Chain-of-custody fields (sample.cites.rationale,
sample.cites.phase1Fields) are rendered identically; PURPOSE.md
invariant preserved.

Verified: lint clean, 605/605 unit tests passing, build clean.
Bundle: AnalysisResults chunk grew from 256.79 KB to 311.86 KB
(larger import surface from the ui/ barrel; tree-shaking will tighten
this as more components migrate and the import is shared).

https://claude.ai/code/session_01WNtYcWXwn4mVnnjxqT7uAe
---
 apps/ui/src/components/SamplePlayback.tsx | 219 ++++++++++++----------
 1 file changed, 123 insertions(+), 96 deletions(-)

diff --git a/apps/ui/src/components/SamplePlayback.tsx b/apps/ui/src/components/SamplePlayback.tsx
index ffe57133..a47bd671 100644
--- a/apps/ui/src/components/SamplePlayback.tsx
+++ b/apps/ui/src/components/SamplePlayback.tsx
@@ -7,6 +7,14 @@ import {
   generateSamples,
 } from '../services/sampleGenerationClient';
 import { BackendClientError } from '../services/backendPhase1Client';
+import {
+  Button,
+  DeviceRack,
+  Panel,
+  Pill,
+  SectionHeader,
+} from './ui';
+import type { Tone } from './ui';
 
 interface SamplePlaybackProps {
   runId: string | null | undefined;
@@ -31,6 +39,18 @@ const CATEGORY_LABELS: Record<SampleRecord['category'], string> = {
   melody: 'Melody / lead phrase',
 };
 
+type RackStatus = 'idle' | 'active' | 'success' | 'warning' | 'error';
+
+function rackStatusFor(
+  panelStatus: PanelStatus,
+  hasManifest: boolean,
+): RackStatus {
+  if (panelStatus.kind === 'error') return 'error';
+  if (panelStatus.kind === 'generating') return 'active';
+  if (hasManifest) return 'success';
+  return 'idle';
+}
+
 /**
  * Audition panel that renders generated audio clips for the current run.
  *
@@ -98,79 +118,84 @@ export function SamplePlayback({
 
   if (!runId) return null;
 
+  const rackStatus = rackStatusFor(status, Boolean(manifest));
+
   return (
-    <section
-      className="rounded-lg border border-zinc-700 bg-zinc-900/40 p-4 mt-6"
-      aria-labelledby="audition-heading"
-    >
-      <header className="flex items-baseline justify-between gap-3 mb-3">
-        <div>
-          <h3 id="audition-heading" className="text-base font-semibold text-zinc-100">
-            Audition samples (Phase 3 — heuristic)
-          </h3>
-          <p className="text-xs text-zinc-400 mt-1 max-w-xl">
-            Short clips derived from Phase 1 measurements (and Phase 2 context when
-            available) so you can ear-check the measurement chain. These are not
-            Ableton-accurate reconstructions — follow Phase 2 in Live for the
-            production character.
-          </p>
-        </div>
-        {manifest && (
-          <button
-            type="button"
+    <DeviceRack
+      name="AUDITION SAMPLES"
+      subtitle="· Phase 3 heuristic"
+      status={rackStatus}
+      aria-label="Audition samples"
+      className="mt-6"
+      action={
+        manifest && (
+          <Button
+            variant="link"
+            size="sm"
             onClick={() => handleGenerate(true)}
             disabled={status.kind === 'generating'}
-            className="text-xs underline text-zinc-400 hover:text-zinc-200 disabled:opacity-40"
           >
             Regenerate
-          </button>
-        )}
-      </header>
-
-      {!measurementCompleted && (
-        <p className="text-sm text-zinc-400">
-          Measurements still running — audition samples become available once Phase 1
-          completes.
+          </Button>
+        )
+      }
+    >
+      <div className="space-y-3">
+        <p className="font-mono text-[11px] leading-snug text-text-secondary max-w-xl">
+          Short clips derived from Phase 1 measurements (and Phase 2 context when
+          available) so you can ear-check the measurement chain. These are not
+          Ableton-accurate reconstructions — follow Phase 2 in Live for the
+          production character.
         </p>
-      )}
 
-      {measurementCompleted && !manifest && status.kind !== 'generating' && (
-        <button
-          type="button"
-          onClick={() => handleGenerate(false)}
-          disabled={status.kind === 'loading'}
-          className="px-3 py-2 rounded bg-amber-600 text-zinc-50 text-sm font-medium hover:bg-amber-500 disabled:opacity-40"
-        >
-          {status.kind === 'loading' ? 'Checking…' : 'Generate audition samples'}
-        </button>
-      )}
+        {!measurementCompleted && (
+          <p className="font-mono text-[11px] text-text-secondary">
+            Measurements still running — audition samples become available once
+            Phase 1 completes.
+          </p>
+        )}
 
-      {status.kind === 'generating' && (
-        <p className="text-sm text-zinc-300">Rendering audition clips…</p>
-      )}
+        {measurementCompleted && !manifest && status.kind !== 'generating' && (
+          <Button
+            variant="primary"
+            size="md"
+            ledIndicator
+            onClick={() => handleGenerate(false)}
+            disabled={status.kind === 'loading'}
+          >
+            {status.kind === 'loading' ? 'Checking…' : 'Generate audition samples'}
+          </Button>
+        )}
 
-      {status.kind === 'error' && (
-        <p className="text-sm text-red-400" role="alert">
-          {status.message}
-        </p>
-      )}
+        {status.kind === 'generating' && (
+          <p className="font-mono text-[11px] text-text-secondary">
+            Rendering audition clips…
+          </p>
+        )}
 
-      {manifest && groupedSamples.length > 0 && (
-        <div className="space-y-5">
-          <ManifestMeta manifest={manifest} />
-          {groupedSamples.map(([category, samples]) => (
-            <React.Fragment key={category}>
-              <SampleGroup
-                category={category}
-                samples={samples}
-                runId={runId}
-                apiBaseUrl={apiBaseUrl}
-              />
-            </React.Fragment>
-          ))}
-        </div>
-      )}
-    </section>
+        {status.kind === 'error' && (
+          <p className="font-mono text-[11px] text-error" role="alert">
+            {status.message}
+          </p>
+        )}
+
+        {manifest && groupedSamples.length > 0 && (
+          <div className="space-y-5">
+            <ManifestMeta manifest={manifest} />
+            {groupedSamples.map(([category, samples]) => (
+              <React.Fragment key={category}>
+                <SampleGroup
+                  category={category}
+                  samples={samples}
+                  runId={runId}
+                  apiBaseUrl={apiBaseUrl}
+                />
+              </React.Fragment>
+            ))}
+          </div>
+        )}
+      </div>
+    </DeviceRack>
   );
 }
 
@@ -184,13 +209,9 @@ function ManifestMeta({ manifest }: { manifest: SamplesManifest }) {
       ? 'PyTheory'
       : 'Pure-Python theory fallback';
   return (
-    <div className="flex flex-wrap gap-2 text-xs">
-      <span className="rounded-full bg-zinc-800 px-2 py-0.5 text-zinc-300">
-        Music theory: {theoryLabel}
-      </span>
-      <span className="rounded-full bg-zinc-800 px-2 py-0.5 text-zinc-300">
-        Synthesis: {synthesisLabel}
-      </span>
+    <div className="flex flex-wrap gap-1.5">
+      <Pill tone="neutral" leadingDot>Music theory: {theoryLabel}</Pill>
+      <Pill tone="neutral" leadingDot>Synthesis: {synthesisLabel}</Pill>
     </div>
   );
 }
@@ -204,15 +225,18 @@ interface SampleGroupProps {
 
 function SampleGroup({ category, samples, runId, apiBaseUrl }: SampleGroupProps) {
   return (
-    <div>
-      <h4 className="text-sm font-medium text-zinc-200 mb-2">
-        {CATEGORY_LABELS[category]}
-      </h4>
-      <ul className="space-y-3">
+    <div className="space-y-2">
+      <SectionHeader
+        size="sm"
+        eyebrow="Group"
+        title={CATEGORY_LABELS[category]}
+        ledTone="accent"
+      />
+      <ul className="space-y-2 list-none p-0">
         {samples.map((sample) => (
-          <React.Fragment key={sample.id}>
+          <li key={sample.id}>
             <SampleCard sample={sample} runId={runId} apiBaseUrl={apiBaseUrl} />
-          </React.Fragment>
+          </li>
         ))}
       </ul>
     </div>
@@ -233,15 +257,16 @@ function SampleCard({ sample, runId, apiBaseUrl }: SampleCardProps) {
     ? artifactStreamUrl(runId, sample.midiArtifactId, apiBaseUrl)
     : null;
 
+  const tone = confidenceTone(sample.confidence, sample.lowConfidence);
+  const label = sample.lowConfidence
+    ? 'Low confidence'
+    : `${sample.confidence} confidence`;
+
   return (
-    <li className="rounded-md border border-zinc-800 bg-zinc-900/60 p-3">
+    <Panel variant="surface" padding="md">
       <div className="flex items-baseline justify-between gap-3 mb-2">
-        <span className="text-sm text-zinc-100">{sample.label}</span>
-        <span
-          className={`text-[10px] uppercase tracking-wide px-1.5 py-0.5 rounded ${confidenceClassFor(sample.confidence, sample.lowConfidence)}`}
-        >
-          {sample.lowConfidence ? 'Low confidence' : `${sample.confidence} confidence`}
-        </span>
+        <span className="font-mono text-[12px] text-text-primary">{sample.label}</span>
+        <Pill tone={tone} size="xs">{label}</Pill>
       </div>
       {audioUrl ? (
         <audio
@@ -252,16 +277,18 @@ function SampleCard({ sample, runId, apiBaseUrl }: SampleCardProps) {
           aria-label={`Audition sample: ${sample.label}`}
         />
       ) : (
-        <p className="text-xs text-zinc-500">Audio stream unavailable.</p>
+        <p className="font-mono text-[11px] text-text-muted">Audio stream unavailable.</p>
       )}
-      <p className="text-xs text-zinc-400 mt-2">{sample.cites.rationale}</p>
+      <p className="font-mono text-[11px] text-text-secondary mt-2">
+        {sample.cites.rationale}
+      </p>
       {sample.cites.phase1Fields.length > 0 && (
-        <p className="text-xs text-zinc-500 mt-1">
+        <p className="font-mono text-[11px] text-text-muted mt-1">
           Cites:{' '}
           {sample.cites.phase1Fields.map((field, idx) => (
             <React.Fragment key={field}>
               {idx > 0 && ', '}
-              <code className="text-zinc-300 bg-zinc-800/60 rounded px-1">
+              <code className="text-text-primary bg-bg-app/60 rounded px-1 py-0.5 border border-border/40">
                 {field}
               </code>
             </React.Fragment>
@@ -269,10 +296,10 @@ function SampleCard({ sample, runId, apiBaseUrl }: SampleCardProps) {
         </p>
       )}
       {midiUrl && (
-        <p className="text-xs text-zinc-500 mt-1">
+        <p className="font-mono text-[11px] text-text-muted mt-1">
           <a
             href={midiUrl}
-            className="underline hover:text-zinc-300"
+            className="text-accent underline underline-offset-2 hover:text-accent/80"
             download={sample.midiFilename ?? `${sample.id}.mid`}
           >
             Download MIDI
@@ -280,17 +307,17 @@ function SampleCard({ sample, runId, apiBaseUrl }: SampleCardProps) {
           to audition with your own instruments in Ableton.
         </p>
       )}
-    </li>
+    </Panel>
   );
 }
 
-function confidenceClassFor(
+function confidenceTone(
   confidence: SampleRecord['confidence'],
   lowConfidence: boolean,
-): string {
-  if (lowConfidence || confidence === 'LOW') return 'bg-amber-900/40 text-amber-300';
-  if (confidence === 'MED') return 'bg-zinc-700 text-zinc-200';
-  return 'bg-emerald-900/40 text-emerald-300';
+): Tone {
+  if (lowConfidence || confidence === 'LOW') return 'warning';
+  if (confidence === 'MED') return 'neutral';
+  return 'success';
 }
 
 function friendlyError(err: unknown): string {

From 28a9ac4c57e33bd7d2c313cefc554a8a1396617c Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Mon, 18 May 2026 22:35:29 +0000
Subject: [PATCH 2/2] fix(ui): DeviceRack signal rail uses 3 explicit slots

PR #65 review flagged that when signalIn, railContent, and signalOut
are all set together, both railContent and signalOut carried ml-auto.
In a flex row only the first ml-auto sibling claims the available
space, so signalOut collapsed against railContent instead of
anchoring to the far right.

Restructure the rail as three fixed slots: a left container for
signalIn, a flex-1 center for railContent, and a right-justified
container for signalOut. Each slot always renders; empty when its
content is absent. Layout is now consistent across all combinations
of the three slot props.

PR #66 doesn't exercise the all-three-slots case (SamplePlayback only
sets status, not the rail), but D.4 (AnalysisStatusPanel migration)
will, so worth fixing now while the primitive has no production
consumers.

Verified: lint clean, 605/605 unit tests passing.

https://claude.ai/code/session_01WNtYcWXwn4mVnnjxqT7uAe
---
 apps/ui/src/components/ui/DeviceRack.tsx | 36 +++++++++++++++---------
 1 file changed, 23 insertions(+), 13 deletions(-)

diff --git a/apps/ui/src/components/ui/DeviceRack.tsx b/apps/ui/src/components/ui/DeviceRack.tsx
index d964664d..09018cfd 100644
--- a/apps/ui/src/components/ui/DeviceRack.tsx
+++ b/apps/ui/src/components/ui/DeviceRack.tsx
@@ -95,20 +95,30 @@ export const DeviceRack = React.forwardRef<HTMLDivElement, DeviceRackProps>(
         )}
         <div className={cn(bodyVariants({ density }))}>{children}</div>
         {showRail && (
+          // Three explicit slots so signalIn / railContent / signalOut land
+          // left / center / right regardless of which combination is present.
+          // (Previously two adjacent `ml-auto` siblings collapsed signalOut
+          // next to railContent when all three slots were filled.)
           <div className="device-rack__rail">
-            {signalIn != null && (
-              <span className="flex items-center gap-1">
-                <span className="signal-arrow" data-tone={signalIn} />
-                <span>in</span>
-              </span>
-            )}
-            {railContent && <span className="ml-auto truncate">{railContent}</span>}
-            {signalOut != null && (
-              <span className="ml-auto flex items-center gap-1">
-                <span>out</span>
-                <span className="signal-arrow" data-tone={signalOut} />
-              </span>
-            )}
+            <span className="flex items-center gap-1 min-w-0">
+              {signalIn != null && (
+                <>
+                  <span className="signal-arrow" data-tone={signalIn} />
+                  <span>in</span>
+                </>
+              )}
+            </span>
+            <span className="flex-1 min-w-0 truncate text-center">
+              {railContent}
+            </span>
+            <span className="flex items-center gap-1 min-w-0 justify-end">
+              {signalOut != null && (
+                <>
+                  <span>out</span>
+                  <span className="signal-arrow" data-tone={signalOut} />
+                </>
+              )}
+            </span>
           </div>
         )}
       </div>