feat: port solana grant role#33
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested a review
from DimitriosNaikopoulos
ajaskolski
force-pushed
the
feat-port-solana-grant-role
branch
from
85f09f9 to
a952942
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the Solana “grant role” functionality (from the Chainlink repo) into this repo’s MCMS changesets/operations layer, enabling granting Timelock roles to one or more Solana accounts either via direct deployer execution or via an MCMS proposal flow.
Changes:
- Added a Solana operation + sequence to grant a Timelock role to one or multiple accounts (direct-send or MCMS-transaction output).
- Added a Solana changeset that validates environment/state and builds MCMS batch operations / proposals for role granting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
mcms/operations/grant_role_timelock.go |
Introduces a Solana operation/sequence for granting Timelock roles and optionally producing MCMS transactions. |
mcms/changesets/grant_role_timelock.go |
Adds a changeset wrapper that loads Solana MCMS/Timelock state, executes the sequence, and builds an MCMS proposal when configured. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ecPablo
approved these changes
May 5, 2026
Contributor
|
One suggestion before removing the changesets from core repo is to search on all the org for usages to see if there's any other usages outside of the core repo that we might need to swap import for first. |
Contributor
Author
Thanks, roger that. Gladly it was mentioned in the ticket so that's what I planned there ! |
jkongie
added a commit
that referenced
this pull request
May 6, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.0](cld-changesets-v0.0.1...cld-changesets-v0.1.0) (2026-05-06) ### Features * add "catalog create chain metadata" changeset ([#36](#36)) ([c12bb51](c12bb51)) * add catalog create contract metadata changeset ([#27](#27)) ([8ec1cbc](8ec1cbc)) * add CRE workflow deploy changeset and operation ([#1](#1)) ([960fde1](960fde1)) * add target name param to cre deploy changeset ([#3](#3)) ([8b25662](8b25662)) * fund mcms pdas ([#22](#22)) ([821e542](821e542)) * **jobspec:** port jobspec changesets from chainlink ([#21](#21)) ([0ce3f74](0ce3f74)) * link token ([#30](#30)) ([07345c1](07345c1)) * **pkg:** add contract constants and Solana MCMS state loading ([#5](#5)) ([6a2bbee](6a2bbee)) * port BuildProposalFromBatchesV2 ([#24](#24)) ([28d53d7](28d53d7)) * port run changeset from chainlink ([#32](#32)) ([693922f](693922f)) * port solana grant role ([#33](#33)) ([7eca5be](7eca5be)) * port token approve ([#40](#40)) ([04130de](04130de)) * **port:** firedrill mcms with operations api refactor ([#25](#25)) ([6d9010c](6d9010c)) * **solana:** add SOL funding helpers for deployer transfers ([#19](#19)) ([63bebf8](63bebf8)) * **solana:** port over mcms pda loader ([#11](#11)) ([7170ddc](7170ddc)) ### Bug Fixes * **aptos:** move state load ([#8](#8)) ([de58102](de58102)) * **evm:** port state load evm funcs ([#9](#9)) ([99279f1](99279f1)) * **state:** restore addressbook usage ([#17](#17)) ([017cd5e](017cd5e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com> Co-authored-by: James Kong <61834+jkongie@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports grant role from chainlink repo.
https://smartcontract-it.atlassian.net/browse/CLD-1923