Skip to content

feat!: delete Link state views#68

Merged
jkongie merged 1 commit into
mainfrom
delete-link-views
May 25, 2026
Merged

feat!: delete Link state views#68
jkongie merged 1 commit into
mainfrom
delete-link-views

Conversation

@jkongie
Copy link
Copy Markdown
Collaborator

@jkongie jkongie commented May 25, 2026

BREAKING CHANGE: Removes the LinkToken and StaticLinkToken state views from the public API.

BREAKING CHANGE: Removes the LinkToken and StaticLinkToken state views
from the public API.
Copilot AI review requested due to automatic review settings May 25, 2026 13:35
@jkongie jkongie requested a review from a team as a code owner May 25, 2026 13:35
@github-actions
Copy link
Copy Markdown

👋 jkongie, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the LinkToken and StaticLinkToken “state view” types from the module’s public API (breaking change), along with their associated view generation helpers and tests.

Changes:

  • Deleted the LinkTokenView / GenerateLinkTokenView implementation.
  • Deleted the StaticLinkTokenView / GenerateStaticLinkTokenView implementation.
  • Removed unit/integration tests that exercised those view generators.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
pkg/contract/link/view/v10/static_link_token.go Removed the StaticLinkTokenView type and generator from the public API.
pkg/contract/link/view/v10/static_link_token_test.go Removed tests covering GenerateStaticLinkTokenView.
pkg/contract/link/view/v10/link_token.go Removed the LinkTokenView type and generator from the public API.
pkg/contract/link/view/v10/link_token_test.go Removed tests covering GenerateLinkTokenView (including zk-specific test).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jkongie jkongie merged commit d5f643b into main May 25, 2026
17 checks passed
@jkongie jkongie deleted the delete-link-views branch May 25, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants