Skip to content

feat!: delete ApproveToken helper#70

Merged
jkongie merged 1 commit into
mainfrom
remove-approve-token
May 25, 2026
Merged

feat!: delete ApproveToken helper#70
jkongie merged 1 commit into
mainfrom
remove-approve-token

Conversation

@jkongie
Copy link
Copy Markdown
Collaborator

@jkongie jkongie commented May 25, 2026

BREAKING CHANGE: Deletes the ApproveToken helper and related tests.

This was a helper method that was used by legacy changesets which were no longer used.

BREAKING CHANGE: Deletes the ApproveToken helper and related tests.

This was a helper method that was used by legacy changesets which were
no longer used.
@jkongie jkongie requested a review from a team as a code owner May 25, 2026 15:47
Copilot AI review requested due to automatic review settings May 25, 2026 15:47
@github-actions
Copy link
Copy Markdown

👋 jkongie, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the legacy ApproveToken helper from pkg/cldfutil/changeset and deletes its associated tests, as it is no longer used by any changesets in this repository (breaking change).

Changes:

  • Deleted ApproveToken helper (ERC20 approval helper for EVM chains).
  • Removed the simulated-EVM unit tests that exercised ApproveToken.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/cldfutil/changeset/token_approve.go Removed the unused ApproveToken helper implementation.
pkg/cldfutil/changeset/token_approve_test.go Removed tests that only validated the deleted helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jkongie jkongie enabled auto-merge (squash) May 25, 2026 16:18
@jkongie jkongie merged commit 83f59e7 into main May 25, 2026
17 checks passed
@jkongie jkongie deleted the remove-approve-token branch May 25, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants