feat: add ExecutePayer field in chain metadata for setting solana execute accounts [CLD-3046] - #814
Merged
Merged
Conversation
…as signers in proposal transformation Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
ecPablo
changed the title
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
ecPablo
marked this pull request as ready for review
July 10, 2026 19:59
ecPablo
marked this pull request as draft
July 10, 2026 19:59
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
ecPablo
marked this pull request as draft
July 11, 2026 01:12
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
Signed-off-by: Pablo <pablo.estrada@smartcontract.com>
giogam
approved these changes
Jul 14, 2026
|
ecPablo
pushed a commit
that referenced
this pull request
Jul 14, 2026
🤖 I have created a release *beep* *boop* --- ## [0.52.0](v0.51.0...v0.52.0) (2026-07-14) ### Features * add ExecutePayer field in chain metadata for setting solana execute accounts [CLD-3046] ([#814](#814)) ([4e1ae4b](4e1ae4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). [CLD-3046]: https://smartcontract-it.atlassian.net/browse/CLD-3046?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: app-token-issuer-ops-platform[bot] <275822481+app-token-issuer-ops-platform[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for a new
ExecutePayerfield toAdditionalFieldsMetadatain solana SDK so that bypass proposals that have instructions that list the deployer key on the accounts metadata can be correctly update to theisSignerflag totrue.AI Summary
This pull request introduces support for an optional
executePayerfield in Solana Timelock chain metadata, addressing a critical edge case for bypass proposals. The main motivation is to ensure that when the Solana fee payer (who pays for and signs the transaction) is also present as a writable remaining account in a bypass operation, the Merkle leaf hash computed off-chain matches the on-chain verification, preventing proof failures. The changes include SDK enhancements, documentation updates, and a comprehensive end-to-end test to both demonstrate and guard against the signer-bit mismatch bug.Solana Timelock Bypass Execute Payer Support
SDK and Core Logic:
ExecutePayerfield toAdditionalFieldsMetadatainsdk/solana/chain_metadata.go, with helper methodsWithExecutePayerandHasExecutePayer. The bypass operation logic now applies a signer override to the fee payer if present in metadata, ensuring Merkle hashes align with on-chain expectations. [1] [2] [3]Testing:
e2e/tests/solana/timelock_bypass_payer_collision.go) that demonstrates both the failure mode (proof cannot be verified) and the successful bypass whenexecutePayeris set.AdditionalFieldsMetadatato cover JSON serialization/deserialization and the new helper methods. [1] [2]Documentation:
executePayerfield, its necessity for Solana bypass proposals, usage guidance, and a reference to the new test scenario. [1] [2] [3]