Skip to content

Make consul::install optional#135

Merged
solarkennedy merged 3 commits intovoxpupuli:masterfrom
potto007:optional-install
Jun 12, 2015
Merged

Make consul::install optional#135
solarkennedy merged 3 commits intovoxpupuli:masterfrom
potto007:optional-install

Conversation

@potto007
Copy link
Contributor

Added a check against $install_method for the string 'none'. If found, nothing is downloaded or installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme is good for the full example, but can you update the inline docstring on init.pp:13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that, I overlooked the docstring. Updated.

@solarkennedy
Copy link
Contributor

Looks great! Thanks.

solarkennedy added a commit that referenced this pull request Jun 12, 2015
@solarkennedy solarkennedy merged commit bac60a9 into voxpupuli:master Jun 12, 2015
@potto007 potto007 deleted the optional-install branch June 12, 2015 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants