Add hostname proprety for ACL operations, defaults to localhost, like before#219
Merged
solarkennedy merged 2 commits intovoxpupuli:masterfrom Jan 23, 2016
Merged
Conversation
Contributor
|
If you could add tests that would be great for this one as well. Also it would probably be fine to combine these two together into a single pull request if you'd like. Otherwise we might end up with having to do some merge conflict resolution since this and your other are changing several of the same lines of code. |
Contributor
Author
|
Tests will be on their way soon. As for the merge conflicts, I'll handle them, I'd rather keep logically different changes in different PRs |
Contributor
|
Looks good to me. @Split3 second opinion? |
Contributor
|
Yes agree, looks good, thanks for adding the test! |
solarkennedy
added a commit
that referenced
this pull request
Jan 23, 2016
Add hostname proprety for ACL operations, defaults to localhost, like before
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216