Normalize tangents after applying vertex transform

Norbyte · Norbyte · commit 426c4e16bd21 · 2023-07-31T18:43:51.000+02:00
diff --git a/LSLib/Granny/Model/Vertex.cs b/LSLib/Granny/Model/Vertex.cs
@@ -392,9 +392,9 @@ public void FinalizeInfluences()
         public void Transform(Matrix4 transformation, Matrix4 inverse)
         {
             Position = Vector3.TransformPosition(Position, transformation);
-            Normal = Vector3.TransformNormalInverse(Normal, inverse);
-            Tangent = Vector3.TransformNormalInverse(Tangent, inverse);
-            Binormal = Vector3.TransformNormalInverse(Binormal, inverse);
+            Normal = Vector3.Normalize(Vector3.TransformNormalInverse(Normal, inverse));
+            Tangent = Vector3.Normalize(Vector3.TransformNormalInverse(Tangent, inverse));
+            Binormal = Vector3.Normalize(Vector3.TransformNormalInverse(Binormal, inverse));
         }
 
         public void Serialize(WritableSection section)

Original file line number	Diff line number	Diff line change
`@@ -392,9 +392,9 @@ public void FinalizeInfluences()`
`392`	`392`	`public void Transform(Matrix4 transformation, Matrix4 inverse)`
`393`	`393`	`{`
`394`	`394`	`Position = Vector3.TransformPosition(Position, transformation);`
`395`		`- Normal = Vector3.TransformNormalInverse(Normal, inverse);`
`396`		`- Tangent = Vector3.TransformNormalInverse(Tangent, inverse);`
`397`		`- Binormal = Vector3.TransformNormalInverse(Binormal, inverse);`
	`395`	`+ Normal = Vector3.Normalize(Vector3.TransformNormalInverse(Normal, inverse));`
	`396`	`+ Tangent = Vector3.Normalize(Vector3.TransformNormalInverse(Tangent, inverse));`
	`397`	`+ Binormal = Vector3.Normalize(Vector3.TransformNormalInverse(Binormal, inverse));`
`398`	`398`	`}`
`399`	`399`
`400`	`400`	`public void Serialize(WritableSection section)`