From a4fa8a3e88ea1b1af4fb05aeec1436138d5c7c0b Mon Sep 17 00:00:00 2001 From: Damian Tarnawski Date: Thu, 2 Jan 2025 18:35:30 +0100 Subject: [PATCH 1/2] dev: Add `internal` flag to signal --- packages/solid/src/reactive/signal.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/solid/src/reactive/signal.ts b/packages/solid/src/reactive/signal.ts index fd1ab94d2..23b8af7c9 100644 --- a/packages/solid/src/reactive/signal.ts +++ b/packages/solid/src/reactive/signal.ts @@ -82,6 +82,8 @@ export interface SignalState extends SourceMapValue { observerSlots: number[] | null; tValue?: T; comparator?: (prev: T, next: T) => boolean; + // development-only + internal?: true; } export interface Owner { @@ -233,8 +235,12 @@ export function createSignal( if ("_SOLID_DEV_") { if (options.name) s.name = options.name; - if (DevHooks.afterCreateSignal) DevHooks.afterCreateSignal(s); - if (!options.internal) registerGraph(s); + if (options.internal) { + s.internal = true; + } else { + registerGraph(s); + if (DevHooks.afterCreateSignal) DevHooks.afterCreateSignal(s); + } } const setter: Setter = (value?: unknown) => { From 9ad77851c1a1e3f7b19b6d1ecd3d7022be804c21 Mon Sep 17 00:00:00 2001 From: Ryan Carniato Date: Fri, 21 Feb 2025 11:03:50 -0800 Subject: [PATCH 2/2] Create eighty-parents-scream.md --- .changeset/eighty-parents-scream.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eighty-parents-scream.md diff --git a/.changeset/eighty-parents-scream.md b/.changeset/eighty-parents-scream.md new file mode 100644 index 000000000..0d21a4fe9 --- /dev/null +++ b/.changeset/eighty-parents-scream.md @@ -0,0 +1,5 @@ +--- +"solid-js": patch +--- + +dev: Add `internal` flag to signal