From 32bd8671be7e8ccee577a3a4fb18d9107e4e0076 Mon Sep 17 00:00:00 2001
From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Date: Thu, 5 Mar 2026 00:22:25 +0000
Subject: [PATCH 1/2] Exclude test classes from CommentDefaultAccessModifier
 rule

Add violationSuppressXPath property to suppress CommentDefaultAccessModifier
violations in test classes (matching pattern: Test*, IT*, *Test, *Tests,
*TestCase, *IT, *ITCase).

Co-Authored-By: lithium147@gmail.com <timlwalters@yahoo.co.uk>
---
 src/main/resources/pmd7-rules.xml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/main/resources/pmd7-rules.xml b/src/main/resources/pmd7-rules.xml
index 63850da..d8b62d9 100644
--- a/src/main/resources/pmd7-rules.xml
+++ b/src/main/resources/pmd7-rules.xml
@@ -86,8 +86,9 @@
             <!-- Ignore @Nested -->
             <property name="ignoredAnnotations"
                       value="android.support.annotation.VisibleForTesting,co.elastic.clients.util.VisibleForTesting,com.google.common.annotations.VisibleForTesting,org.junit.jupiter.api.AfterAll,org.junit.jupiter.api.AfterEach,org.junit.jupiter.api.BeforeAll,org.junit.jupiter.api.BeforeEach,org.junit.jupiter.params.ParameterizedTest,junit.extensions.RepeatedTest,org.junit.jupiter.api.Test,org.junit.jupiter.api.TestFactory,org.junit.jupiter.api.TestTemplate,org.junit.jupiter.api.extension.RegisterExtension,org.junit.jupiter.api.Nested,com.intuit.karate.junit5.Karate.Test,com.intuit.karate.junit5.Karate"/>
-            <!-- ignore test related methods -->
-            <!-- TODO ignore constructors of test classes -->
+            <!-- Exclude test classes -->
+            <property name="violationSuppressXPath"
+                      value=".[ancestor-or-self::ClassDeclaration[matches(@SimpleName, '^(Test|IT).*$|^[A-Z][a-zA-Z0-9]*Test(s|Case)?$|^[A-Z][a-zA-Z0-9]*IT(Case)?$')]]"/>
             <property name="regex" value="\/\*\s*(default|package)\s*\*\/"/>
         </properties>
     </rule>

From 215eedd41f00fb085b0deb5c19f5ee66d2218e4a Mon Sep 17 00:00:00 2001
From: twalters <timlwalters@yahoo.co.uk>
Date: Thu, 5 Mar 2026 00:37:16 +0000
Subject: [PATCH 2/2] Exclude test classes from CommentDefaultAccessModifier

---
 src/main/resources/pmd7-rules.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/resources/pmd7-rules.xml b/src/main/resources/pmd7-rules.xml
index d8b62d9..ac06b4e 100644
--- a/src/main/resources/pmd7-rules.xml
+++ b/src/main/resources/pmd7-rules.xml
@@ -86,7 +86,7 @@
             <!-- Ignore @Nested -->
             <property name="ignoredAnnotations"
                       value="android.support.annotation.VisibleForTesting,co.elastic.clients.util.VisibleForTesting,com.google.common.annotations.VisibleForTesting,org.junit.jupiter.api.AfterAll,org.junit.jupiter.api.AfterEach,org.junit.jupiter.api.BeforeAll,org.junit.jupiter.api.BeforeEach,org.junit.jupiter.params.ParameterizedTest,junit.extensions.RepeatedTest,org.junit.jupiter.api.Test,org.junit.jupiter.api.TestFactory,org.junit.jupiter.api.TestTemplate,org.junit.jupiter.api.extension.RegisterExtension,org.junit.jupiter.api.Nested,com.intuit.karate.junit5.Karate.Test,com.intuit.karate.junit5.Karate"/>
-            <!-- Exclude test classes -->
+            <!-- Exclude test classes - ideally would have separate rules for main and test -->
             <property name="violationSuppressXPath"
                       value=".[ancestor-or-self::ClassDeclaration[matches(@SimpleName, '^(Test|IT).*$|^[A-Z][a-zA-Z0-9]*Test(s|Case)?$|^[A-Z][a-zA-Z0-9]*IT(Case)?$')]]"/>
             <property name="regex" value="\/\*\s*(default|package)\s*\*\/"/>