This repository was archived by the owner on Oct 16, 2020. It is now read-only.
Only return InsertTextFormat.Snippet when a snippet is returned - #363
Merged
felixfbecker merged 1 commit intoOct 3, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 74.71% 74.68% -0.03%
==========================================
Files 15 15
Lines 1760 1758 -2
Branches 332 331 -1
==========================================
- Hits 1315 1313 -2
Misses 294 294
Partials 151 151
Continue to review full report at Codecov.
|
felixfbecker
approved these changes
Oct 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The language server was returning InsertTextFormat.Snippet all the time when a client indicated it supported snippets.
The more correct behaviour is to only return that value when insertText is actually a snippet.
This allows clients to avoid potentially more complex completion handling when not necessary.