This repository was archived by the owner on Oct 16, 2020. It is now read-only.
fix(codefix): correct hover information for type signatures with callbacks - #415
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 15 15
Lines 2038 2038
Branches 482 482
=======================================
Hits 1695 1695
- Misses 341 343 +2
+ Partials 2 0 -2
Continue to review full report at Codecov.
|
Contributor
|
Could you add a test for this to prevent regressions? |
Contributor
Author
|
I cannot read the output from |
Contributor
|
Just run |
Contributor
Author
|
Wohoo! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #413