GRAPH-775 annotation processing fix #732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without closing the print writer, empty message was produced.
| exception.printStackTrace(new PrintWriter(baos)); | ||
| PrintWriter pw = new PrintWriter(baos); | ||
| exception.printStackTrace(pw); | ||
| pw.close(); |
Contributor
Author
There was a problem hiding this comment.
This line is responsible for not seeing the root cause error message.
I've seen this type of empty message multiple times in customer reports:
[ERROR] /Users/mwang/code/mwang/scip-java-test/src/main/java/com/imc/mwang/Foo.java:[1] error: semanticdb-javac:
🤞 going forward we'll be able to get more meaningful error reports.
olafurpg
approved these changes
Aug 6, 2024
Contributor
olafurpg
left a comment
olafurpg
left a comment
There was a problem hiding this comment.
Very clean fix. Nice work tracking this down! 👏🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #727
Turns out we weren't handling the unary trees at all, and they're allowed to be values in annotation parameters.
This PR adds support for them.
Test plan