Fix callMethodOnDumper treating false config values as no-argument calls (#1961)

* Fix callMethodOnDumper treating false as no-argument call

When a dump config option like skip_ssl is set to false, callMethodOnDumper
was calling the method with no arguments because of the falsy check:

    if (! $methodValue) { $dbDumper->$methodName(); }

setSkipSsl() has a default parameter of true, so calling it with no
arguments sets skipSsl to true even when the config says false.

Change the check to $methodValue === null so only genuinely absent
values (flag-style options like use_single_transaction) invoke
the no-argument form. Falsy values like false and 0 are now passed
through correctly.

Fixes: #1946

* Reset custom dumpers in beforeEach to fix test isolation

The 'custom dumpers' test registers a MongoDb factory for 'mysql'
via the static $custom property, which persisted into subsequent
tests causing the skip_ssl test to get a MongoDb instance instead
of MySql.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Freek Van der Herten <freek@spatie.be>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: 3 people

src/Tasks/Backup/DbDumperFactory.php

@@ -121,7 +121,7 @@ protected static function processExtraDumpParameters(array $dumpConfiguration, D
 
     protected static function callMethodOnDumper(DbDumper $dbDumper, string $methodName, mixed $methodValue): DbDumper
     {
-        if (! $methodValue) {
+        if ($methodValue === null) {
             $dbDumper->$methodName();
 
             return $dbDumper;

tests/DbDumperFactoryTest.php

@@ -9,6 +9,10 @@
 use Spatie\DbDumper\Databases\Sqlite;
 
 beforeEach(function () {
+    $reflection = new \ReflectionClass(DbDumperFactory::class);
+    $property = $reflection->getProperty('custom');
+    $property->setValue(null, []);
+
     config()->set('database.default', 'mysql');
 
     config()->set('database.connections.mariadb', [
@@ -220,3 +224,26 @@ function getDumpCommand(): string
 
     return DbDumperFactory::createFromConnection('mysql')->getDumpCommand($dumpFile, $credentialsFile);
 }
+
+it('respects skip_ssl false when set in dump config', function () {
+    $dbConfig = [
+        'driver' => 'mysql',
+        'host' => 'localhost',
+        'database' => 'myDb',
+        'username' => 'root',
+        'password' => 'myPassword',
+        'dump' => [
+            'skip_ssl' => false,
+        ],
+    ];
+
+    config()->set('database.connections.mysql', $dbConfig);
+
+    $dumper = DbDumperFactory::createFromConnection('mysql');
+
+    $reflection = new \ReflectionClass($dumper);
+    $property = $reflection->getProperty('skipSsl');
+    $property->setAccessible(true);
+
+    expect($property->getValue($dumper))->toBeFalse();
+});