Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Commit e1629b6

Browse files
committed
Format test checkstyle
- Relates #162
1 parent 091b94a commit e1629b6

File tree

3 files changed

+23
-25
lines changed

3 files changed

+23
-25
lines changed

src/test/java/org/springframework/cli/command/ProjectCatalogInitializerTests.java

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,22 @@ void testPropertyOverride() {
8484
});
8585
}
8686

87+
@Test
88+
void testWithExistingProjectCatalog() {
89+
ApplicationContextRunner contextRunner = new ApplicationContextRunner().withUserConfiguration(
90+
ProjectCatalogInitializerTests.ProjectCatalogInitializerWithExistingCatalogConfig.class);
91+
contextRunner.run((context) -> {
92+
assertThat(context).hasSingleBean(ProjectCatalogCommands.class);
93+
ProjectCatalogCommands projectCatalogCommands = context.getBean(ProjectCatalogCommands.class);
94+
Table table = (Table) projectCatalogCommands.catalogList(false);
95+
assertThat(table.getModel().getRowCount()).isEqualTo(2);
96+
TableAssertions.verifyTableValue(table, 1, 0, "fooname");
97+
TableAssertions.verifyTableValue(table, 1, 1, "foodescription");
98+
TableAssertions.verifyTableValue(table, 1, 2, "foourl");
99+
TableAssertions.verifyTableValue(table, 1, 3, "[footag1, footag2]");
100+
});
101+
}
102+
87103
@Configuration
88104
@EnableConfigurationProperties(SpringCliProjectCatalogProperties.class)
89105
static class ProjectCatalogInitializerConfig {
@@ -120,22 +136,6 @@ ProjectCatalogInitializer projectCatalogInitializer(SpringCliUserConfig springCl
120136

121137
}
122138

123-
@Test
124-
void testWithExistingProjectCatalog() {
125-
ApplicationContextRunner contextRunner = new ApplicationContextRunner().withUserConfiguration(
126-
ProjectCatalogInitializerTests.ProjectCatalogInitializerWithExistingCatalogConfig.class);
127-
contextRunner.run((context) -> {
128-
assertThat(context).hasSingleBean(ProjectCatalogCommands.class);
129-
ProjectCatalogCommands projectCatalogCommands = context.getBean(ProjectCatalogCommands.class);
130-
Table table = (Table) projectCatalogCommands.catalogList(false);
131-
assertThat(table.getModel().getRowCount()).isEqualTo(2);
132-
TableAssertions.verifyTableValue(table, 1, 0, "fooname");
133-
TableAssertions.verifyTableValue(table, 1, 1, "foodescription");
134-
TableAssertions.verifyTableValue(table, 1, 2, "foourl");
135-
TableAssertions.verifyTableValue(table, 1, 3, "[footag1, footag2]");
136-
});
137-
}
138-
139139
@Configuration
140140
@EnableConfigurationProperties(SpringCliProjectCatalogProperties.class)
141141
static class ProjectCatalogInitializerWithExistingCatalogConfig {

src/test/java/org/springframework/cli/support/CommandRunner.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
import static org.assertj.core.api.Assertions.fail;
4141
import static org.mockito.Mockito.mock;
4242

43-
public class CommandRunner {
43+
public final class CommandRunner {
4444

4545
private final ApplicationContext context;
4646

src/test/java/org/springframework/cli/support/MockConfigurations.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
import com.google.common.jimfs.Jimfs;
2525
import org.jline.terminal.Terminal;
26+
import org.mockito.Mockito;
2627

2728
import org.springframework.cli.command.BootCommands;
2829
import org.springframework.cli.command.CommandCommands;
@@ -47,9 +48,6 @@
4748
import org.springframework.rewrite.boot.autoconfigure.RewriteLauncherConfiguration;
4849
import org.springframework.shell.style.ThemeResolver;
4950

50-
import static org.mockito.Mockito.mock;
51-
import static org.mockito.Mockito.when;
52-
5351
public class MockConfigurations {
5452

5553
@Configuration
@@ -58,13 +56,13 @@ public static class MockBaseConfig {
5856

5957
@Bean
6058
Terminal terminal() {
61-
Terminal mockTerminal = mock(Terminal.class);
59+
Terminal mockTerminal = Mockito.mock(Terminal.class);
6260
return mockTerminal;
6361
}
6462

6563
@Bean
6664
ThemeResolver themeResolver() {
67-
ThemeResolver mockThemeResolver = mock(ThemeResolver.class);
65+
ThemeResolver mockThemeResolver = Mockito.mock(ThemeResolver.class);
6866
return mockThemeResolver;
6967
}
7068

@@ -130,19 +128,19 @@ public static class MockFakeUserConfig {
130128

131129
@Bean
132130
SpringCliUserConfig springCliUserConfig() {
133-
SpringCliUserConfig mock = mock(SpringCliUserConfig.class);
131+
SpringCliUserConfig mock = Mockito.mock(SpringCliUserConfig.class);
134132
ProjectRepository pr1 = ProjectRepository.of("jpa", "Learn JPA",
135133
"https://github.com/rd-1-2022/rpt-spring-data-jpa", null);
136134
ProjectRepository pr2 = ProjectRepository.of("scheduling", "Scheduling",
137135
"https://github.com/rd-1-2022/rpt-spring-scheduling-tasks", null);
138136
ProjectRepositories prs = new ProjectRepositories();
139137
prs.setProjectRepositories(Arrays.asList(pr1, pr2));
140-
when(mock.getProjectRepositories()).thenReturn(prs);
138+
Mockito.when(mock.getProjectRepositories()).thenReturn(prs);
141139
ProjectCatalogs pcs = new ProjectCatalogs();
142140
ProjectCatalog pc = ProjectCatalog.of("getting-started", "Spring Getting Started Projects",
143141
"https://github.com/rd-1-2022/spring-gs-catalog/", null);
144142
pcs.setProjectCatalogs(Arrays.asList(pc));
145-
when(mock.getProjectCatalogs()).thenReturn(pcs);
143+
Mockito.when(mock.getProjectCatalogs()).thenReturn(pcs);
146144
return mock;
147145
}
148146

0 commit comments

Comments
 (0)