add materialized view support#1509
Merged
kyleconroy merged 1 commit intosqlc-dev:mainfrom Mar 29, 2022
Merged
Conversation
ludusrusso
force-pushed
the
add-materialized-view-and-create-table-as-support
branch
from
af92724 to
b3275c4
Compare
Contributor
|
@ludusrusso I believe you intended on tagging @kyleconroy! |
Contributor
Author
|
😂😂 yep! Sorry!! |
kyleconroy
requested changes
Mar 25, 2022
Collaborator
kyleconroy
left a comment
kyleconroy
left a comment
There was a problem hiding this comment.
Since this is implemented via CREATE TABLE AS, can we also add a test case for that statement?
ludusrusso
force-pushed
the
add-materialized-view-and-create-table-as-support
branch
from
b3275c4 to
07a8e96
Compare
Contributor
Author
Fix your suggestions and add a new test case for |
|
third party bump, looks like comments are addressed cc @kyleconroy was trying to use materialized views today so happy to see this on the finish line 😄 |
kyleconroy
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Adds materialized view support.
Fix #1021
@kylecarbs it was a little bit hard to understand that
CREATE MATERIALIZED VIEWare treatedCREATE TABLE ASunder the hood. It seems working, what do you think?