Deflake test and fix Alpine compat note

Author: Ben Creech

.github/workflows/pypi-build.yml

@@ -54,10 +54,11 @@ jobs:
           # build distro):
           - image: debian:bullseye
           - image: arm64v8/debian:bullseye
-          # And for Alpine we mostly measure compatibility in musl minor versions, and
-          # the oldest supported Alpine as of this writing (3.16) has the same minor
-          # version as 3.19, so use 3.19. (This helps bring a newer system clang, which
-          # works better with the V8 build.)
+          # Alpine 3.19 includes a clang new enough for V8 to build (with only minor
+          # patches!). Builds on 3.19 seem incompatible with <= 3.18 due to libstdc++
+          # symbols. (And we can't just run on an old Alpine and update clang from the
+          # llvm site, because unlike Debian, the llvm project doesn't maintain
+          # updated packages for old Alpine distros.)
           - image: alpine:3.19
           - image: arm64v8/alpine:3.19
 

README.md

@@ -114,7 +114,7 @@ PyMiniRacer is distributed using [wheels](https://pythonwheels.com/) on
 | Debian ≥ 11                     | ✓      | ✓       |
 | RHEL ≥ 8                        | ✓      | ✓       |
 | other Linuxes with glibc ≥ 2.31 | ✓      | ✓       |
-| Alpine ≥ 3.16                   | ✓      | ✓       |
+| Alpine ≥ 3.19                   | ✓      | ✓       |
 | other Linux with musl ≥ 1.2     | ✓      | ✓       |
 
 If you have a up-to-date pip and it doesn't use a wheel, you might have an environment

tests/test_eval.py

@@ -82,15 +82,17 @@ def test_null_byte():
 
 
 def test_timeout():
-    timeout_ms = 100
+    timeout = 0.1
     start_time = time()
 
     mr = MiniRacer()
     with pytest.raises(JSTimeoutException):
-        mr.eval("while(1) { }", timeout=timeout_ms)
+        mr.eval("while(1) { }", timeout=int(timeout * 1000))
 
     duration = time() - start_time
-    assert timeout_ms <= duration * 1000 <= timeout_ms + 200
+    # Make sure it timed out on time, and allow a giant leeway (because aarch64
+    # emulation tests are surprisingly slow!)
+    assert timeout <= duration <= timeout + 5
 
 
 def test_max_memory_soft():
@@ -144,13 +146,17 @@ def test_async():
     const shared = new SharedArrayBuffer(8);
     const view = new Int32Array(shared);
 
-    const p = Atomics.waitAsync(view, 0, 0, 1); // 1 ms timeout
+    const p = Atomics.waitAsync(view, 0, 0, 1000); // 1 s timeout
     p.value.then(() => { done = true; });
     done
     """
     )
-    sleep(0.1)
     assert not mr.eval("done")
+    start = time()
+    # Give the 1-second wait 10 seconds to finish. (Emulated aarch64 tests are
+    # surprisingly slow!)
+    while time() - start < 10 and not mr.eval("done"):
+        sleep(0.1)
     assert mr.eval("done")