fix(messages): Improve prettify(..) helper and assertion messages #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseLion
force-pushed
the
fix/prettify-helper
branch
from
2e243e9 to
8ce9642
Compare
JoseLion
force-pushed
the
fix/prettify-helper
branch
from
8ce9642 to
11237c4
Compare
dalejo96
approved these changes
Jan 2, 2024
Contributor
dalejo96
left a comment
dalejo96
left a comment
There was a problem hiding this comment.
LGTM! Just left a small comment not a blocker.
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves how the
.prettify(..)helper works to get more human-readable representations of JavaScript data types. As part of the change, some assertion messages have also been improved.