feat(function): Refactor FunctionAssertion and add ErrorAssertion #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseLion
requested review from
Alex0jk,
alejo0o,
byrpatrick,
dalejo96,
elcuy and
flandrade
Alex0jk
reviewed
May 17, 2022
Contributor
Alex0jk
left a comment
Alex0jk
left a comment
There was a problem hiding this comment.
Looks pretty good. I like the error assertion addition, and how it plays with the function assertion.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the
TypeFactorieschange we added, I found now possible to refactor theFunctionAssertionmethods to give a better experience when checking for errors thrown.@Alex0jk since you did the first iteration of
FunctionAssertion, please let me know what you think about the change 🙂