correctly handle f.Close error

Kai Kummerer · Kai Kummerer · commit 384b9f7cc169 · 2024-04-16T11:06:11.000+02:00
diff --git a/internal/pkg/config/config.go b/internal/pkg/config/config.go
@@ -91,7 +91,13 @@ func InitConfig() {
 			cobra.CheckErr(err)
 		}
 	}
-	defer f.Close() //nolint:errcheck // file close errors are hard to handle
+	defer func() {
+		if f != nil {
+			if err := f.Close(); err != nil {
+				cobra.CheckErr(err)
+			}
+		}
+	}()
 
 	setConfigDefaults()
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,13 @@ func InitConfig() {`
`91`	`91`	`cobra.CheckErr(err)`
`92`	`92`	`}`
`93`	`93`	`}`
`94`		`- defer f.Close() //nolint:errcheck // file close errors are hard to handle`
	`94`	`+ defer func() {`
	`95`	`+ if f != nil {`
	`96`	`+ if err := f.Close(); err != nil {`
	`97`	`+ cobra.CheckErr(err)`
	`98`	`+ }`
	`99`	`+ }`
	`100`	`+ }()`
`95`	`101`
`96`	`102`	`setConfigDefaults()`
`97`	`103`