From 52d0c89dff57364aaa673fa7ec049702f96ddbc7 Mon Sep 17 00:00:00 2001 From: Moritz Clasmeier Date: Wed, 13 May 2026 11:40:09 +0200 Subject: [PATCH] SEnd SIGKILL and simplify --- internal/portforward/portforward.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/internal/portforward/portforward.go b/internal/portforward/portforward.go index b62f69cb..410dede5 100644 --- a/internal/portforward/portforward.go +++ b/internal/portforward/portforward.go @@ -100,13 +100,8 @@ func (m *Manager) Start(namespace, serviceName string, remotePort, preferredLoca // Wait for port to be ready if !m.waitTCPReady("127.0.0.1", localPort, 20.0) { - // Kill the process group if cmd.Process != nil { - pgid, err := syscall.Getpgid(cmd.Process.Pid) - if err == nil { - syscall.Kill(-pgid, syscall.SIGTERM) - } - // TODO(ROX-34499): AFAICT this can get stuck forever if the process blocks SIGTERM... + cmd.Process.Kill() cmd.Wait() } return "", fmt.Errorf("port-forward did not become ready")