Merge pull request fzaninotto#681 from ravage84/patch-1

Do not generate special purpose IPv4s

Author: fzaninotto

src/Faker/Provider/Internet.php

@@ -288,7 +288,7 @@ public function slug($nbWords = 6, $variableNbWords = true)
      */
     public function ipv4()
     {
-        return long2ip(mt_rand(0, 1) == 0 ? mt_rand(-2147483648, 0) : mt_rand(1, 2147483647));
+        return long2ip(mt_rand(0, 1) == 0 ? mt_rand(-2147483648, -2) : mt_rand(16777216, 2147483647));
     }
 
     /**

test/Faker/Provider/InternetTest.php

@@ -108,6 +108,16 @@ public function testIpv4()
         $this->assertNotFalse(filter_var($this->faker->ipv4(), FILTER_VALIDATE_IP, FILTER_FLAG_IPV4));
     }
 
+    public function testIpv4NotLocalNetwork()
+    {
+        $this->assertNotRegExp('/\A1\./', $this->faker->ipv4());
+    }
+
+    public function testIpv4NotBroadcast()
+    {
+        $this->assertNotEquals('255.255.255.255', $this->faker->ipv4());
+    }
+
     public function testIpv6()
     {
         $this->assertNotFalse(filter_var($this->faker->ipv6(), FILTER_VALIDATE_IP, FILTER_FLAG_IPV6));