improve e2e tests

Author: Cyril de Catheu

thirdeye-integration-tests/src/test/java/ai/startree/thirdeye/SchedulerQuotaTest.java

@@ -85,6 +85,8 @@ public class SchedulerQuotaTest {
   public void beforeClass() throws Exception {
     // ensure time is controlled via the TimeProvider CLOCK - ie weaving is working correctly
     assertThat(CLOCK.isTimeMockWorking()).isTrue();
+    // mock time before the support is created to mock time in the ScheduledExecutors 
+    CLOCK.useMockTime(new DateTime(2025, 1, 1, 0, 0, 1, DateTimeZone.UTC).getMillis());
 
     support.setup();
     pinotDataSourceApi = support.getPinotDataSourceApi();
@@ -132,7 +134,7 @@ public void testVerifyTaskQuotas() {
 
   @Test(dependsOnMethods = "testVerifyTaskQuotas")
   public void testTaskIsCreated() {
-    CLOCK.useMockTime(new DateTime(2025, 1, 1, 0, 0, 1, DateTimeZone.UTC).getMillis());
+    // current time is 2025/1/1 00:00:01
     // create alert that schedules every 10 seconds
     final Response response = client.request("api/alerts")
         .post(Entity.json(List.of(ALERT_API)));

thirdeye-integration-tests/src/test/java/ai/startree/thirdeye/SchedulingTest.java

@@ -99,6 +99,8 @@ public class SchedulingTest {
   public void beforeClass() throws Exception {
     // ensure time is controlled via the TimeProvider CLOCK - ie weaving is working correctly
     assertThat(CLOCK.isTimeMockWorking()).isTrue();
+    // mock time before support creation to mock time in ScheduledExecutors
+    CLOCK.useMockTime(MARCH_24_2020_15H33);
 
     support.setup();
     pinotDataSourceApi = support.getPinotDataSourceApi();
@@ -134,8 +136,7 @@ public void setUpData() {
 
   @Test(dependsOnMethods = "setUpData")
   public void testCreateAlertLastTimestamp() {
-    // fix clock : time is now controlled manually
-    CLOCK.useMockTime(MARCH_24_2020_15H33);
+    // current time is  MARCH_24_2020_15H33
 
     final Response createResponse = client.request("api/alerts")
         .post(Entity.json(List.of(ALERT_API)));

thirdeye-integration-tests/src/test/resources/anomalyresolution/config/server.yaml

@@ -76,9 +76,9 @@ scheduler:
   detectionPipeline: true
   detectionAlert: true
 
-  # disable task clean up by making the interval big - FIXME CYRIL introduce special value 0 instead
+  # disable task clean up 
   taskCleanUp:
-    intervalInMinutes: 2147483647
+    intervalInMinutes: 0
 
 ui:
   externalUrl: http://localhost:7004

thirdeye-integration-tests/src/test/resources/scheduling/config/server.yaml

@@ -74,4 +74,8 @@ scheduler:
 
   detectionPipeline: true
   detectionAlert: true
+  
+  # disable task clean up 
+  taskCleanUp:
+    intervalInMinutes: 0
 

thirdeye-integration-tests/src/test/resources/schedulingquota/config/server.yaml

@@ -75,8 +75,10 @@ scheduler:
 
   detectionPipeline: true
   detectionAlert: true
-
-  namespaceQuotaCacheDurationSeconds: 0
+  
+  # disable task clean up 
+  taskCleanUp:
+    intervalInMinutes: 0
 
 defaultWorkspaceConfiguration:
   timeConfiguration: