Merge branch 'master' into free-tier-feedback

nalin-patidar · nalin-patidar · commit 8022be1a5a9c · 2025-01-28T14:34:40.000+05:30
diff --git a/.github/workflows/fe-e2e.yaml b/.github/workflows/fe-e2e.yaml
@@ -3,11 +3,20 @@ on:
   push:
     branches:
       - master
+  pull_request:
+    types:
+      - opened
+      - edited
+      - ready_for_review
+      - synchronize
+    branches:
+      - master
   workflow_dispatch:
 jobs:
   test:
     timeout-minutes: 60
     runs-on: ubuntu-latest
+    if: github.event.pull_request.draft == false
     steps:
       - name: Pull Repository
         uses: actions/checkout@v4
diff --git a/jacoco-code-coverage/pom.xml b/jacoco-code-coverage/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
 
   <artifactId>jacoco-code-coverage</artifactId>
diff --git a/pinot-test-container/pom.xml b/pinot-test-container/pom.xml
@@ -18,7 +18,7 @@
     <parent>
         <artifactId>thirdeye</artifactId>
         <groupId>ai.startree.thirdeye</groupId>
-        <version>1.414.0-SNAPSHOT</version>
+        <version>1.416.0-SNAPSHOT</version>
     </parent>
     <modelVersion>4.0.0</modelVersion>
 
diff --git a/pom.xml b/pom.xml
@@ -18,7 +18,7 @@
   <modelVersion>4.0.0</modelVersion>
   <groupId>ai.startree.thirdeye</groupId>
   <artifactId>thirdeye</artifactId>
-  <version>1.414.0-SNAPSHOT</version>
+  <version>1.416.0-SNAPSHOT</version>
   <packaging>pom</packaging>
   <name>thirdeye</name>
 
diff --git a/thirdeye-benchmarks/pom.xml b/thirdeye-benchmarks/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
 
   <artifactId>thirdeye-benchmarks</artifactId>
diff --git a/thirdeye-core/pom.xml b/thirdeye-core/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <artifactId>thirdeye-core</artifactId>
 
diff --git a/thirdeye-dataframe/pom.xml b/thirdeye-dataframe/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
 
   <modelVersion>4.0.0</modelVersion>
diff --git a/thirdeye-detectionpipeline/pom.xml b/thirdeye-detectionpipeline/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <artifactId>thirdeye-detectionpipeline</artifactId>
 
diff --git a/thirdeye-detectionpipeline/src/main/java/ai/startree/thirdeye/detectionpipeline/Operator.java b/thirdeye-detectionpipeline/src/main/java/ai/startree/thirdeye/detectionpipeline/Operator.java
@@ -26,22 +26,12 @@ void execute()
 
   String getOperatorName();
 
-  void setProperty(String key, Object value);
-
-
   /**
    * Set keyed input
-   * @param key
-   * @param input
    */
+  @SuppressWarnings("unused") // used in enterprise TE
   void setInput(String key, OperatorResult input);
 
-  /**
-   * Get keyed output
-   * @param key
-   */
-  OperatorResult getOutput(String key);
-
   /**
    * Get all keyed outputs
    */
diff --git a/thirdeye-detectionpipeline/src/main/java/ai/startree/thirdeye/detectionpipeline/operator/DetectionPipelineOperator.java b/thirdeye-detectionpipeline/src/main/java/ai/startree/thirdeye/detectionpipeline/operator/DetectionPipelineOperator.java
@@ -94,16 +94,6 @@ protected void setOutput(String key, final OperatorResult output) {
     resultMap.put(key, output);
   }
 
-  @Override
-  public void setProperty(final String key, final Object value) {
-    planNode.getParams().putValue(key, value);
-  }
-
-  @Override
-  public OperatorResult getOutput(final String key) {
-    return resultMap.get(key);
-  }
-
   @Override
   public Map<String, OperatorResult> getOutputs() {
     return resultMap;
diff --git a/thirdeye-distribution/pom.xml b/thirdeye-distribution/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye</artifactId>
     <groupId>ai.startree.thirdeye</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-integration-tests/pom.xml b/thirdeye-integration-tests/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye</artifactId>
     <groupId>ai.startree.thirdeye</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-notification/pom.xml b/thirdeye-notification/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <artifactId>thirdeye-notification</artifactId>
 
diff --git a/thirdeye-persistence/pom.xml b/thirdeye-persistence/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye</artifactId>
     <groupId>ai.startree.thirdeye</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/pom.xml b/thirdeye-plugins/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye</artifactId>
     <groupId>ai.startree.thirdeye</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/thirdeye-bootstrap-open-core/pom.xml b/thirdeye-plugins/thirdeye-bootstrap-open-core/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/thirdeye-contributors-simple/pom.xml b/thirdeye-plugins/thirdeye-contributors-simple/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/thirdeye-detectors/pom.xml b/thirdeye-plugins/thirdeye-detectors/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/thirdeye-enumerators/pom.xml b/thirdeye-plugins/thirdeye-enumerators/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/thirdeye-notification-email/pom.xml b/thirdeye-plugins/thirdeye-notification-email/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/thirdeye-oauth/pom.xml b/thirdeye-plugins/thirdeye-oauth/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-plugins/thirdeye-pinot/pom.xml b/thirdeye-plugins/thirdeye-pinot/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
     <relativePath>..</relativePath>
   </parent>
   <modelVersion>4.0.0</modelVersion>
diff --git a/thirdeye-plugins/thirdeye-plugin-example/pom.xml b/thirdeye-plugins/thirdeye-plugin-example/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
     <relativePath>..</relativePath>
   </parent>
   <modelVersion>4.0.0</modelVersion>
diff --git a/thirdeye-plugins/thirdeye-postprocessors/pom.xml b/thirdeye-plugins/thirdeye-postprocessors/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <artifactId>thirdeye-plugins</artifactId>
     <groupId>ai.startree.thirdeye.plugins</groupId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-scheduler/pom.xml b/thirdeye-scheduler/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <artifactId>thirdeye-scheduler</artifactId>
 
diff --git a/thirdeye-server/pom.xml b/thirdeye-server/pom.xml
@@ -18,7 +18,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
   <modelVersion>4.0.0</modelVersion>
 
diff --git a/thirdeye-server/src/main/java/ai/startree/thirdeye/exception/GenericExceptionMapper.java b/thirdeye-server/src/main/java/ai/startree/thirdeye/exception/GenericExceptionMapper.java
@@ -44,10 +44,10 @@ public GenericExceptionMapper() {
   @Override
   public Response toResponse(final Throwable exception) {
     final ThirdEyeStatus status = statusFor(exception);
-    LOG.debug(
+    LOG.error(
         "Request failed because of a {}. Returning error code {}",
         exception.getClass().getSimpleName(),
-        status.getRecommendedStatusCode());
+        status.getRecommendedStatusCode(), exception);
     final StatusApi statusApi = new StatusApi()
         .setCode(status)
         .setMsg(exception.getMessage())
diff --git a/thirdeye-spi/pom.xml b/thirdeye-spi/pom.xml
@@ -19,7 +19,7 @@
   <parent>
     <groupId>ai.startree.thirdeye</groupId>
     <artifactId>thirdeye</artifactId>
-    <version>1.414.0-SNAPSHOT</version>
+    <version>1.416.0-SNAPSHOT</version>
   </parent>
 
   <modelVersion>4.0.0</modelVersion>
diff --git a/thirdeye-ui/e2e/pages/alert-detail.ts b/thirdeye-ui/e2e/pages/alert-detail.ts
@@ -39,6 +39,41 @@ export class AlertDetailsPage extends BasePage {
         this.alertsApiResponseData = await alertsApiResponse.json();
     }
 
+    async resolveDetailsPageApis() {
+        await Promise.all([
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes("/api/alerts/insights") &&
+                    response.status() === 200
+            ),
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes("/api/alerts") &&
+                    response.status() === 200
+            ),
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes("/api/enumeration-items") &&
+                    response.status() === 200
+            ),
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes("/api/anomalies") &&
+                    response.status() === 200
+            ),
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes("/stats") &&
+                    response.status() === 200
+            ),
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes("/api/alerts/evaluate") &&
+                    response.status() === 200
+            ),
+        ]);
+    }
+
     async resolveAnomaliesApis() {
         const [anomaliesApiResponse] = await Promise.all([
             this.page.waitForResponse(
@@ -277,4 +312,36 @@ export class AlertDetailsPage extends BasePage {
                 .filter({ hasText: "Heatmap & Dimension Drills" })
         ).toBeDefined();
     }
+
+    async applyDateChange() {
+        const calnedarButton = this.page.getByTestId("open-calendar-button");
+        await calnedarButton.click();
+        const availableDates = this.page.locator(
+            ".MuiPickersDay-day:not(.MuiPickersDay-daySelected):not(.MuiPickersDay-dayDisabled)"
+        );
+        const count = await availableDates.count();
+        const newStartDate = availableDates.nth(1);
+        const newEndDate = availableDates.nth(count - 2);
+        newStartDate.click();
+        newEndDate.click();
+        const applyDateBtn = this.page.getByTestId("apply-button");
+        applyDateBtn.click();
+        await Promise.all([
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes(`/api/anomalies`) &&
+                    response.status() === 200
+            ),
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes(`/stats`) &&
+                    response.status() === 200
+            ),
+            this.page.waitForResponse(
+                (response) =>
+                    response.url().includes(`/api/alerts/evaluate`) &&
+                    response.status() === 200
+            ),
+        ]);
+    }
 }
diff --git a/thirdeye-ui/e2e/pages/alert-list.ts b/thirdeye-ui/e2e/pages/alert-list.ts
@@ -207,7 +207,10 @@ export class AlertListPage extends BasePage {
 
         const jsonEditor = this.page.locator(".CodeMirror");
         await jsonEditor.click();
-        const editedAlert = `{"id": ${topAlert.id}, "name": "Clicks_SUM_mean-variance-rule-dup-edit","description": "","template": {"name": "startree-mean-variance"},"templateProperties": {"dataSource": "pinot","dataset": "AdCampaignData","aggregationColumn": "Clicks","aggregationFunction": "SUM","monitoringGranularity": "P1D","timezone": "UTC","queryFilters": "","sensitivity": "-6","lookback": "P21D"},"cron": "0 0 5 ? * MON-FRI *","auth": {"namespace": null}}`;
+        const date = new Date();
+        const editedAlert = `{"id": ${
+            topAlert.id
+        }, "name": "Clicks_SUM_mean-variance-rule-dup-edit${date.getTime()}","description": "","template": {"name": "startree-mean-variance"},"templateProperties": {"dataSource": "pinot","dataset": "AdCampaignData","aggregationColumn": "Clicks","aggregationFunction": "SUM","monitoringGranularity": "P1D","timezone": "UTC","queryFilters": "","sensitivity": "-6","lookback": "P21D"},"cron": "0 0 5 ? * MON-FRI *","auth": {"namespace": null}}`;
         await this.page.evaluate((editedAlert) => {
             const editor = document.querySelector(".CodeMirror")?.CodeMirror;
             editor.setValue(editedAlert);
@@ -253,10 +256,13 @@ export class AlertListPage extends BasePage {
         await expect(saveButtonAfterLoadChart).toBeEnabled();
         await expect(saveButtonAfterLoadChart).toHaveText("Update Alert");
 
-        const updateApiRequest = this.page.waitForRequest("/api/alerts");
-        const updateApiResponse = this.page.waitForResponse("/api/alerts");
         saveButtonAfterLoadChart.click();
 
+        const updateButtonModal = this.page.locator(`.MuiDialog-paper button`);
+        const updateBtn = updateButtonModal.nth(1);
+        const updateApiRequest = this.page.waitForRequest("/api/alerts");
+        const updateApiResponse = this.page.waitForResponse("/api/alerts");
+        updateBtn.click();
         const updateAlertRequest = await updateApiRequest;
 
         const updateAlertResponse = await updateApiResponse;
diff --git a/thirdeye-ui/e2e/tests/alert-details.spec.ts b/thirdeye-ui/e2e/tests/alert-details.spec.ts
diff --git a/thirdeye-ui/src/app/components/time-range/time-range-selector/time-range-selector/time-range-selector.interfaces.ts b/thirdeye-ui/src/app/components/time-range/time-range-selector/time-range-selector/time-range-selector.interfaces.ts
diff --git a/thirdeye-ui/src/app/pages/alerts-create-page/alerts-create-base-page.component.tsx b/thirdeye-ui/src/app/pages/alerts-create-page/alerts-create-base-page.component.tsx
diff --git a/thirdeye-ui/src/app/pages/alerts-view-page/alerts-view-page.component.tsx b/thirdeye-ui/src/app/pages/alerts-view-page/alerts-view-page.component.tsx
diff --git a/thirdeye-worker/pom.xml b/thirdeye-worker/pom.xml
