diff --git a/lang/en/fieldtypes.php b/lang/en/fieldtypes.php index 3372248b244..df2ed07b900 100644 --- a/lang/en/fieldtypes.php +++ b/lang/en/fieldtypes.php @@ -5,7 +5,7 @@ 'any.config.cast_booleans' => 'Options with values of true and false will be saved as booleans.', 'any.config.mode' => 'Choose your preferred UI style.', 'array.config.expand' => 'Whether to save the array in the expanded format. Use this if you intend to have numeric values.', - 'array.config.keys' => 'Set the array keys (variables) and optional labels.', + 'array.config.keys' => 'Set the array keys (variables) and their optional labels.', 'array.config.mode' => 'The **dynamic** mode gives the user free control of the data, while **keyed** and **single** modes enforce strict keys.', 'array.title' => 'Array', 'assets.config.allow_uploads' => 'Allow new file uploads.', @@ -154,7 +154,7 @@ 'range.config.step' => 'The minimum size between values.', 'range.title' => 'Range', 'relationship.config.mode' => 'Choose your preferred UI style.', - 'replicator.config.button_label' => 'Add a label to the add set button.', + 'replicator.config.button_label' => 'Customize the label of the "Add Set" button.', 'replicator.config.collapse' => 'The set collapsing behavior.', 'replicator.config.collapse.accordion' => 'Only allow one set to be expanded at a time.', 'replicator.config.collapse.disabled' => 'All sets expanded by default.', @@ -164,7 +164,7 @@ 'replicator.config.previews' => 'Show a preview of the content inside a set while collapsed.', 'replicator.config.sets' => 'Sets are configurable blocks of fields that can be created and reordered as desired.', 'replicator.title' => 'Replicator', - 'revealer.config.input_label' => 'Set a label to be shown in the button or beside the toggle.', + 'revealer.config.input_label' => 'Customize the label of the "Show Fields" button, or the label beside the toggle.', 'revealer.config.mode' => 'Choose your preferred UI style.', 'revealer.title' => 'Revealer', 'section.title' => 'Section', diff --git a/src/Fieldtypes/Grid.php b/src/Fieldtypes/Grid.php index 6add77b8ee7..bc6ed23baf8 100644 --- a/src/Fieldtypes/Grid.php +++ b/src/Fieldtypes/Grid.php @@ -55,6 +55,7 @@ protected function configFieldItems(): array 'display' => __('Add Row Label'), 'instructions' => __('statamic::fieldtypes.grid.config.add_row'), 'type' => 'text', + 'placeholder' => __('Add Row'), 'width' => 50, ], 'reorderable' => [ diff --git a/src/Fieldtypes/Lists.php b/src/Fieldtypes/Lists.php index 265d6b1fdc9..8c42cb374ad 100644 --- a/src/Fieldtypes/Lists.php +++ b/src/Fieldtypes/Lists.php @@ -21,7 +21,7 @@ protected function configFieldItems(): array 'type' => 'list', ], 'add_row' => [ - 'display' => __('Add Row Label'), + 'display' => __('Add Item Label'), 'instructions' => __('statamic::fieldtypes.list.config.add_row'), 'type' => 'text', 'placeholder' => __('Add Item'), diff --git a/src/Fieldtypes/Replicator.php b/src/Fieldtypes/Replicator.php index f5a094a7389..816098c086f 100644 --- a/src/Fieldtypes/Replicator.php +++ b/src/Fieldtypes/Replicator.php @@ -75,6 +75,7 @@ protected function configFieldItems(): array 'display' => __('Add Set Label'), 'instructions' => __('statamic::fieldtypes.replicator.config.button_label'), 'type' => 'text', + 'placeholder' => __('Add Set'), 'default' => '', 'width' => 50, ], diff --git a/tests/Fieldtypes/GridTest.php b/tests/Fieldtypes/GridTest.php index cb5d1e15536..5424400ebda 100644 --- a/tests/Fieldtypes/GridTest.php +++ b/tests/Fieldtypes/GridTest.php @@ -521,6 +521,17 @@ public function augment($value) ], collect($augmented)->toArray()); } + #[Test] + public function it_has_add_row_config() + { + $configFields = collect((new \ReflectionMethod(Grid::class, 'configFieldItems'))->invoke(new Grid)) + ->flatMap(fn ($section) => $section['fields']); + + $this->assertSame('text', $configFields['add_row']['type']); + $this->assertSame('Add Row Label', $configFields['add_row']['display']); + $this->assertSame('Add Row', $configFields['add_row']['placeholder']); + } + #[Test] public function it_converts_a_queryable_value() { diff --git a/tests/Fieldtypes/ListTest.php b/tests/Fieldtypes/ListTest.php index 43f86e65d89..9b85cb74762 100644 --- a/tests/Fieldtypes/ListTest.php +++ b/tests/Fieldtypes/ListTest.php @@ -25,6 +25,8 @@ public function it_has_add_row_config() $this->assertArrayHasKey('add_row', $configFields); $this->assertSame('text', $configFields['add_row']['type']); + $this->assertSame('Add Item Label', $configFields['add_row']['display']); + $this->assertSame('Add Item', $configFields['add_row']['placeholder']); } private function field($config = []) diff --git a/tests/Fieldtypes/ReplicatorTest.php b/tests/Fieldtypes/ReplicatorTest.php index 628d2b58688..ea15c10c54c 100644 --- a/tests/Fieldtypes/ReplicatorTest.php +++ b/tests/Fieldtypes/ReplicatorTest.php @@ -1221,6 +1221,17 @@ public function fields_blink_cache_key_is_site_aware() $this->assertSame($frEntry, $frFields->all()->first()->parent()); } + #[Test] + public function it_has_button_label_config() + { + $configFields = collect((new \ReflectionMethod(Replicator::class, 'configFieldItems'))->invoke(new Replicator)) + ->flatMap(fn ($section) => $section['fields']); + + $this->assertSame('text', $configFields['button_label']['type']); + $this->assertSame('Add Set Label', $configFields['button_label']['display']); + $this->assertSame('Add Set', $configFields['button_label']['placeholder']); + } + public static function groupedSetsProvider() { return [