Paginated URL generation#138
Closed
simonhamp wants to merge 6 commits into
Closed
Conversation
Contributor
|
Appreciate you taking the time to PR! ❤️ That said, this one doesn't do much different from @jasonvarga's gist example, which we never felt was ready to merge in. Closing this in favour of #140, which should work for the user automatically without any extra config, while also respecting multisite collection indexes, as well as collection tag per-page settings, filters, query scopes, pagination links, auto_links, etc. 👌 |
Contributor
Author
|
Agreed! Pagination detection feels like a much friendlier solution 👍🏼 nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates, builds on and simplifies #137 (so #137 may be redundant as a result if this is preferred)
Allows the developer to define which URLs are "paginators" and the config they'd like to use to generate the pages in their
config/statamic/ssg.php.Consider the following config:
The generator uses sensible defaults: the page name and URL path part defaults to
'page', and the per-page defaults to10. So you only need to override the parameters you need to change - minimum required iscollection.NB: This DOES NOT create the route for you that will actually render these pages (yet). But in theory, it could... it just needs to capture more information (such as the view, template and entry ID to load). I may add this later.