Shuffle pages#57
Merged
Merged
Conversation
This was referenced Jul 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #54 you can split your pages into chunks to be processed concurrently.
If you have a bunch of similar entries that happen to be slow, or a bunch of manual slow routes, they'll all be grouped together. It's possible one worker will get stuck with a bunch of slow pages, and the other workers will be finished.
By shuffling all the pages, it gives you a better chance that the slow routes will be spread across workers, making the site generate faster overall.
Previously we sorted by URL purely to make the console output nicer. It didn't affect the functionality.