You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Then submit a PR, preferably referencing the relevant issue, if it exists.
104
106
107
+
### Precision for contributors
108
+
Take a look at the (Precision section)[#precision] to get a sense of what we have built in. Also take a look at tests and various assertions.
109
+
If you'd like to improve precision, please also make existing tests more precise, perhaps up to the crate's default set in the `crate::prec` module or better.
110
+
105
111
### Commit messages
106
112
107
113
Please be explicit and and purposeful with commit messages.
Please allow at least one week before pinging issues/pr's.
115
119
116
-
#### Good
120
+
121
+
## Precision
122
+
Floating point is hard! We should try to not unintentionally misuse it. The below text is from the `approx` crate's README and contains useful links.
123
+
> ## References
124
+
> Floating point is hard! Thanks goes to these links for helping to make things a little easier to understand:
125
+
>
126
+
> [Comparing Floating Point Numbers, 2012 Edition](https://randomascii.wordpress.com/2012/02/25/comparing-floating-point-numbers-2012-edition/)
127
+
> [The Floating Point Guide - Comparison](http://floating-point-gui.de/errors/comparison/)
128
+
> [What Every Computer Scientist Should Know About Floating-Point Arithmetic](https://docs.oracle.com/cd/E19957-01/806-3568/ncg_goldberg.html)
129
+
130
+
We have a set of approximation checks in the `prec` module that wrap those from the `approx` crate so that it's easier to have convey blanket precision expectations when appraising this crate. For granularity, one can search for where the options are set otherwise. If you use `rg`, you can run this below command from the crate root.
0 commit comments