Skip to content

Some improvements to generator behavior#1120

Merged
rwjblue merged 1 commit intoember-cli:masterfrom
kimroen:properly-accept-camelCase
Jun 21, 2014
Merged

Some improvements to generator behavior#1120
rwjblue merged 1 commit intoember-cli:masterfrom
kimroen:properly-accept-camelCase

Conversation

@kimroen
Copy link
Contributor

@kimroen kimroen commented Jun 20, 2014

Some assorted generator improvements.

  • Converting belongsTo and hasMany from more formats when generating models. (Previously it wouldn't add model to needs array of test unless already dasherized).
  • Pluralizing attribute name when of type hasMany.
  • Tests for the above and more.
  • Adapter => Serializer in the Serializer test examples to match the other files.
  • Go through a variable in the view test example like in all the others.

kimroen added a commit to kimroen/ember-cli that referenced this pull request Jun 20, 2014
@rwjblue
Copy link
Member

rwjblue commented Jun 21, 2014

Looks good, can you squash?

@stefanpenner
Copy link
Contributor

LGTM, squash + rebase and we can merge

@kimroen
Copy link
Contributor Author

kimroen commented Jun 21, 2014

Done :)

rwjblue added a commit that referenced this pull request Jun 21, 2014
Some improvements to generator behavior
@rwjblue rwjblue merged commit 449927a into ember-cli:master Jun 21, 2014
@kimroen kimroen deleted the properly-accept-camelCase branch June 21, 2014 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants