Skip to content

Ensure that builder cleans directory properly.#1122

Merged
rwjblue merged 1 commit intoember-cli:masterfrom
rwjblue:ensure-directory-is-cleaned-up
Jun 21, 2014
Merged

Ensure that builder cleans directory properly.#1122
rwjblue merged 1 commit intoember-cli:masterfrom
rwjblue:ensure-directory-is-cleaned-up

Conversation

@rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 21, 2014

Prior to this change, only the first item in the directory would be removed
(oops).

Fixes #1118.

Prior to this change, only the first item in the directory would be
removed (oops).
rwjblue added a commit that referenced this pull request Jun 21, 2014
Ensure that builder cleans directory properly.
@rwjblue rwjblue merged commit b893df1 into ember-cli:master Jun 21, 2014
@rwjblue rwjblue deleted the ensure-directory-is-cleaned-up branch June 21, 2014 02:14
@stefanpenner
Copy link
Contributor

nice fix + test, thanks!

@fxxkscript
Copy link

@rjackson @stefanpenner

My project is use PHP as backend language.I need to put a api.php into dist folder.

However this pull request will empty all dist folder.

I fix this bug by ignore .php file in the folder. Is there a better way to do this?

#1275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REGRESSION] On 0.0.36, dist folder is not emptied when building

3 participants