Conversation
|
This is working now, but I still need to get test passing, plus figure it out a better way to proxy testem options. welcome any comments. |
|
<3 |
lib/commands/test.js
Outdated
|
@stefanpenner did some changes and took some of the suggestions made on previous version, I feel comfortable with this as a 0.1 for There is still one issue, tests are actually not being run, can you give me some review on that, I think I'm doing something wrong with le promises. |
tests/unit/commands/test-test.js
Outdated
There was a problem hiding this comment.
this is intentional just to verify that my assertions are not being hit :(
There was a problem hiding this comment.
wanna leave an inline comment?
There was a problem hiding this comment.
@stefanpenner sure, but this "should" be running? Or I did something wrong with the promises?
There was a problem hiding this comment.
@stefanpenner added comment, having a second look trying to figure it out what's up with this. Also will start to work on docs for the website.
|
@abuiles I will review and investigate the issue you are having first thing in the morning. |
thanks 👍 |
tests/unit/commands/test-test.js
Outdated
There was a problem hiding this comment.
@MajorBreakfast could you chime in here? I was expecting this tests to assert but they are not, must be something with the promises.
There was a problem hiding this comment.
you forgot the return statement in line 41.
BTW move the .then() to the next line. -> ARCHITECTURE.md style guide.
There was a problem hiding this comment.
@MajorBreakfast > you forgot the return statement in line 41.
Facepalm... thanks!
|
All fixed here, tests are now running (thanks @MajorBreakfast!) I'll call this a 0.1 🎆 |
tests/unit/commands/test-test.js
Outdated
There was a problem hiding this comment.
inherit from real Task class
There was a problem hiding this comment.
function() { return Promise.resolve() }, then you don't need to stub it. (Also omit true, it's not needed)
There was a problem hiding this comment.
fixed the return value, not inhering for the real Task, this is a stub it's fine to use just an object.
There was a problem hiding this comment.
4 participants
Not ready to be merged yet, but would love feedback as we advance.
Things to do
In the future it would be great to make easy for people to extend/patch task so in the
testcase everyone could write their own on top of their favorite runner and just installed them from bower.