minify css via with clean-css or csso

[luto]

Rework of #484 to statisfy the change-requests.

[luto]

• Just sayin': We should call the option just minifyCSS. cleanCSSConfig is too non-descriptive.
• Yes i like this, I don't like hard-coding the config property as cleanCSSconfig.
• i don't really like tying out css minifier to a specific tool.

[stefanpenner]

can you ad a changelog entry?

[luto]

Done.

PR for gh-pages is in the works.

[MajorBreakfast]

• It should be enabled by default for production builds
• minifyCSS: true should enable it, I think there is nothing wrong with making it configurable by passing in an options object but minifyCSS: true is I think the main use case because it's straightforward

Thx for working on this feature!

[luto]

It is enabled for production by default.. I guess you want to be able to disable it via minifyCSS: false? This key is currently being used to pass options to the minifer. So I propose to change it to:

{ "minifyCSS": {
  "enabled": true,
  "options": { }
} }

Would that be okay with you?

[MajorBreakfast]

Ah yes now I understand. We're only talkin' production. Yes, then minifyCSS: false would be great. There is always somebody who wants to opt out of this kind of feature.

[luto]

Done. I have also clarifed that this is for production only, over in the documentation-PR: #689

[MajorBreakfast]

For what is the enabled key in between? Makes it more complicated to use.

[luto]

Take a look at my comment from half an hour ago.. It is needed because the options for the minifer have to go somewhere.

[MajorBreakfast]

Can't we simply skip the minification step if it's false? The minifier is then a nop anyway.

Sry for being so pesky. :) Ease of use you know...

[luto]

This way you can easily disable the minifer without losing your config. The options object can be left out so the line becomes minifyCSS: { disable: false }, if you never ever want to minify your css. This is short enough, imho.

[luto]

@stefanpenner anything else besides the changelog?

[stefanpenner]

@luto nope: (it does need a rebase though, as it no longer merges cleanly)

[luto]

done