Use web notifications for betterifying your TDD#804
Use web notifications for betterifying your TDD#804stefanpenner merged 1 commit intoember-cli:masterfrom bcardarella:bc-notifications
Conversation
|
I wasn't quite sure how to test web notifications. And I didn't know of a better place to put that code. Feedback welcome and I'll adjust as necessary. |
|
This is of course best used when you are in your code and saving, the test suite auto-reruns and you won't have to switch back to the browser to see the result. |
|
Very cool. I like. |
|
very cool. Is it possible to extract as much as possible to a bower project. This will make upgrading easier |
|
Nice! On Friday, May 23, 2014, Stefan Penner notifications@github.com wrote:
|
|
iLike |
blueprint/tests/test-loader.js
Outdated
There was a problem hiding this comment.
maybe?
!!QUnit.urlParams.notificationIf your browser supports web notifications a new `Notifications` checkbox will appear in the toolbar menu. When checked a `Fail` notification will show when any tests have failed and a `Pass` notification will show when all tests are green. Tomsters added for scale. Support for this feature is added through ember-qunit-notifications
|
ping @stefanpenner, everything has been extracted into two libraries:
I tried to move everything out of |
Use web notifications for betterifying your TDD
|
This is cool! however it causes the this error running Affects I know we're pre-release so just adding this here in case the note is useful to someone upgrading. However, I wonder if there is a way to safely do the import? |
|
@davidjrice did you run |
|
they seem to be in the new blueprint: https://github.com/stefanpenner/ember-cli/blob/master/blueprints/app/files/bower.json#L16 |
|
@abuiles yep, but on a version |
|
@bcardarella Is there any config that allows us to turn this on by default when starting |
|
@mfeckie doesn't that run testem? I actually have not tried to use the notifications with testem. I suppose there could be an option added to opt-in to them in your |
|
That's assuming they even work with with testem |
|
@bcardarella, yeah, testem fires up chrome and phantomjs. It's no big deal to click to turn on notifications. Just curious. Thanks for your answer |
If your browser supports web notifications a new
Notificationscheckbox will appear in the toolbar menu. When checked a
Failnotification will show when any tests have failed and a
Passnotification will show when all tests are green. Tomsters added for
scale.