Add integration-test blueprint#985
Merged
twokul merged 1 commit intoember-cli:masterfrom Jun 12, 2014
Merged
Conversation
Contributor
jgwhite
commented
Jun 11, 2014
Member
There was a problem hiding this comment.
I think we need to import Ember from 'ember';.
Contributor
Author
There was a problem hiding this comment.
Good spot. Looks like the blueprint for tests/.jshintrc isn’t strict enough.
Member
|
👍 |
Member
|
Will need a CHANGELOG entry also. |
jgwhite
added a commit
to jgwhite/ember-cli
that referenced
this pull request
Jun 11, 2014
Contributor
Author
|
Done and done 😄 |
tests/acceptance/generate-test.js
Outdated
Contributor
There was a problem hiding this comment.
its often nice to have assertFileEquals(inputFile, expectedFile) this prevents us from having long strings in tests, that are hard to maintain. Those files can live in fixtures/<test-name>/<files>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.