From 2ef1f7072c7b0d5bff5a8a0f5edfe23fd05dc55a Mon Sep 17 00:00:00 2001 From: Frontend Developer Date: Sun, 22 Mar 2026 19:59:30 +0000 Subject: [PATCH] refactor(milestones): remove redundant workItemCount filter logic The manual workItemCount filter in MilestonesPage duplicated the generic client-side filtering provided by DataTable's getValue prop. Also updates wiki API Contract with filterMeta documentation. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../src/pages/MilestonesPage/MilestonesPage.tsx | 16 ++-------------- wiki | 2 +- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/client/src/pages/MilestonesPage/MilestonesPage.tsx b/client/src/pages/MilestonesPage/MilestonesPage.tsx index b539d6627..33fcde645 100644 --- a/client/src/pages/MilestonesPage/MilestonesPage.tsx +++ b/client/src/pages/MilestonesPage/MilestonesPage.tsx @@ -169,20 +169,8 @@ export function MilestonesPage() { } } - // Work item count filter (format: "min:X,max:Y") - const workItemCountFilter = tableState.filters.get('workItemCount')?.value; - if (workItemCountFilter) { - const minMatch = workItemCountFilter.match(/min:([\d.]+)/); - const maxMatch = workItemCountFilter.match(/max:([\d.]+)/); - const filterMin = minMatch ? parseFloat(minMatch[1]) : undefined; - const filterMax = maxMatch ? parseFloat(maxMatch[1]) : undefined; - result = result.filter((m) => { - const val = m.workItemCount ?? 0; - if (filterMin !== undefined && val < filterMin) return false; - if (filterMax !== undefined && val > filterMax) return false; - return true; - }); - } + // Note: workItemCount filtering is handled by DataTable's generic + // client-side filtering via the getValue prop on the column definition. // Sorting if (tableState.sortBy) { diff --git a/wiki b/wiki index 13668ecf3..cba40a27e 160000 --- a/wiki +++ b/wiki @@ -1 +1 @@ -Subproject commit 13668ecf336fc5c623247d6abece4c87b11254d0 +Subproject commit cba40a27e7d910f7d1c45f96abdefa935876cba9