Reset card highlight state when harvesting recycled views

The highlight tracker unwinds through the outgoing item's view, which
harvesting detaches, so a card highlighted at rebuild time would re-attach
with stale highlight rendering and no path to clear it. Clear the highlight
and drop the tracking entry before pooling the view.

Author: bcssewl

Sources/CodexBar/StatusItemController+MenuCardRecycling.swift

@@ -19,10 +19,18 @@ extension StatusItemController {
         self.menuCardViewRecyclePool.removeAll(keepingCapacity: true)
         guard self.canRecycleMenuCardViews(in: menu) else { return }
         guard fromIndex >= 0, fromIndex < menu.items.count else { return }
+        let menuKey = ObjectIdentifier(menu)
         for item in menu.items[fromIndex...] {
             guard let id = item.representedObject as? String else { continue }
             guard let view = item.view, view is any MenuCardMeasuring else { continue }
             guard self.menuCardViewRecyclePool[id] == nil else { continue }
+            // Unhighlight before detaching: the highlight tracker unwinds through the
+            // outgoing item's `view`, which is about to become nil, so a recycled view
+            // would otherwise re-attach visibly highlighted with no path to clear it.
+            if self.highlightedMenuItems[menuKey] === item {
+                self.highlightedMenuItems.removeValue(forKey: menuKey)
+            }
+            (view as? MenuCardHighlighting)?.setHighlighted(false)
             item.view = nil
             self.menuCardViewRecyclePool[id] = view
         }

Tests/CodexBarTests/MenuCardViewRecyclingTests.swift

@@ -138,6 +138,42 @@ extension StatusMenuTests {
         rebuiltView.setHighlighted(false)
     }
 
+    @Test
+    func `harvesting a highlighted card clears its highlight and tracking entry`() {
+        StatusItemController.setMenuRefreshEnabledForTesting(false)
+        let previousRendering = StatusItemController.menuCardRenderingEnabled
+        StatusItemController.menuCardRenderingEnabled = true
+        defer { StatusItemController.menuCardRenderingEnabled = previousRendering }
+
+        let settings = self.makeSettings()
+        settings.statusChecksEnabled = false
+        settings.refreshFrequency = .manual
+        let controller = self.makeRecyclingController(settings: settings)
+        defer { controller.releaseStatusItemsForTesting() }
+
+        let menu = NSMenu()
+        let item = controller.makeMenuCardItem(Text("card"), id: "menuCard", width: 300)
+        menu.addItem(item)
+        controller.menu(menu, willHighlight: item)
+        guard let hosting = item.view as? MenuCardItemHostingView<MenuCardSectionContainerView<Text>>
+        else {
+            Issue.record("expected a card hosting view")
+            return
+        }
+        #expect(hosting.highlightState.isHighlighted)
+        #expect(controller.highlightedMenuItems[ObjectIdentifier(menu)] === item)
+
+        controller.harvestRecyclableMenuCardViews(in: menu, fromIndex: 0)
+        defer { controller.clearMenuCardViewRecyclePool() }
+
+        #expect(!hosting.highlightState.isHighlighted)
+        #expect(controller.highlightedMenuItems[ObjectIdentifier(menu)] == nil)
+
+        let rebuilt = controller.makeMenuCardItem(Text("rebuilt"), id: "menuCard", width: 300)
+        #expect(rebuilt.view === hosting)
+        #expect(!hosting.highlightState.isHighlighted)
+    }
+
     @Test
     func `same id with different content type builds a fresh view`() {
         StatusItemController.setMenuRefreshEnabledForTesting(false)