perf: avoid reflecting nested cost history projects on submenu open

Replace Cost History hosted-submenu String(reflecting:) signatures with a typed visible-content fingerprint so menu-open work no longer traverses nested project/source daily data the UI never renders.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: Yuxin-Qiao

Sources/CodexBar/CostHistoryChartMenuView.swift

@@ -764,6 +764,75 @@ struct CostHistoryChartMenuView: View {
 }
 
 extension CostHistoryChartMenuView {
+    struct RenderFingerprint: Equatable {
+        let currencyCode: String
+        let historyDays: Int
+        let windowLabel: String?
+        let totalCostBitPattern: UInt64?
+        let daily: [DailyEntry]
+        let projects: [VisibleProjectFingerprint]
+    }
+
+    struct VisibleProjectFingerprint: Equatable {
+        let name: String
+        let path: String?
+        let totalTokens: Int?
+        let totalCostBitPattern: UInt64?
+        let visibleSourceCount: Int
+        let sources: [VisibleSourceFingerprint]
+    }
+
+    struct VisibleSourceFingerprint: Equatable {
+        let name: String
+        let path: String?
+        let totalTokens: Int?
+        let totalCostBitPattern: UInt64?
+    }
+
+    static func renderFingerprint(from snapshot: CostUsageTokenSnapshot) -> RenderFingerprint {
+        self.makeRenderFingerprint(RenderFingerprintInputs(
+            currencyCode: snapshot.currencyCode,
+            historyDays: snapshot.historyDays,
+            windowLabel: snapshot.historyLabel,
+            totalCostUSD: snapshot.last30DaysCostUSD,
+            daily: snapshot.daily,
+            projects: snapshot.projects))
+    }
+
+    private struct RenderFingerprintInputs {
+        let currencyCode: String
+        let historyDays: Int
+        let windowLabel: String?
+        let totalCostUSD: Double?
+        let daily: [DailyEntry]
+        let projects: [CostUsageProjectBreakdown]
+    }
+
+    private static func makeRenderFingerprint(_ inputs: RenderFingerprintInputs) -> RenderFingerprint {
+        RenderFingerprint(
+            currencyCode: inputs.currencyCode,
+            historyDays: inputs.historyDays,
+            windowLabel: inputs.windowLabel,
+            totalCostBitPattern: inputs.totalCostUSD.map(\.bitPattern),
+            daily: inputs.daily,
+            projects: Array(inputs.projects.prefix(self.maxVisibleProjectRows)).map { project in
+                let visibleSources = self.visibleProjectSources(project)
+                return VisibleProjectFingerprint(
+                    name: project.name,
+                    path: project.path,
+                    totalTokens: project.totalTokens,
+                    totalCostBitPattern: project.totalCostUSD.map(\.bitPattern),
+                    visibleSourceCount: visibleSources.count,
+                    sources: Array(visibleSources.prefix(self.maxVisibleProjectSourceRows)).map { source in
+                        VisibleSourceFingerprint(
+                            name: source.name,
+                            path: source.path,
+                            totalTokens: source.totalTokens,
+                            totalCostBitPattern: source.totalCostUSD.map(\.bitPattern))
+                    })
+            })
+    }
+
     static func _defaultSelectedDateKeyForTesting(provider: UsageProvider, daily: [DailyEntry]) -> String? {
         self.defaultSelectedDateKey(model: self.makeModel(provider: provider, daily: daily))
     }

Sources/CodexBar/StatusItemController+HostedSubmenus.swift

@@ -3,6 +3,26 @@ import CodexBarCore
 import QuartzCore
 import SwiftUI
 
+enum HostedSubviewContentFingerprint: Equatable {
+    case text(String)
+    case costHistory(CostHistoryChartMenuView.RenderFingerprint)
+}
+
+struct HostedSubviewRenderSignature: Equatable {
+    let chartID: String
+    let providerRawValue: String?
+    let widthBitPattern: UInt64
+    let content: HostedSubviewContentFingerprint
+}
+
+final class HostedSubviewRenderSignatureBox: NSObject {
+    let signature: HostedSubviewRenderSignature
+
+    init(_ signature: HostedSubviewRenderSignature) {
+        self.signature = signature
+    }
+}
+
 extension StatusItemController {
     private struct HostedSubviewIdentity {
         let chartID: String
@@ -153,7 +173,7 @@ extension StatusItemController {
             return
         }
         let signature = self.hostedSubviewRenderSignature(identity: identity, width: width)
-        if self.hostedSubviewRenderSignatures.object(forKey: menu) as String? == signature {
+        if self.hostedSubviewRenderSignatures.object(forKey: menu)?.signature == signature {
             if identity.chartID == Self.zaiHourlyUsageChartID {
                 self.refreshHostedSubviewHeights(in: menu)
             }
@@ -210,7 +230,9 @@ extension StatusItemController {
                 chartID: identity.chartID,
                 providerRawValue: identity.provider?.rawValue ?? identity.providerRawValue)
         }
-        self.hostedSubviewRenderSignatures.setObject(signature as NSString, forKey: menu)
+        self.hostedSubviewRenderSignatures.setObject(
+            HostedSubviewRenderSignatureBox(signature),
+            forKey: menu)
     }
 
     private func hostedSubviewIdentity(for menu: NSMenu)
@@ -240,51 +262,51 @@ extension StatusItemController {
         width: CGFloat)
     {
         let signature = self.hostedSubviewRenderSignature(identity: identity, width: width)
-        self.hostedSubviewRenderSignatures.setObject(signature as NSString, forKey: menu)
+        self.hostedSubviewRenderSignatures.setObject(
+            HostedSubviewRenderSignatureBox(signature),
+            forKey: menu)
     }
 
     private func hostedSubviewRenderSignature(
         identity: HostedSubviewIdentity,
-        width: CGFloat) -> String
+        width: CGFloat) -> HostedSubviewRenderSignature
     {
-        let contentSignature: String = switch identity.chartID {
+        let contentSignature: HostedSubviewContentFingerprint = switch identity.chartID {
         case Self.usageBreakdownChartID:
-            Self.dashboardBreakdownReadinessSignature(
+            .text(Self.dashboardBreakdownReadinessSignature(
                 OpenAIDashboardDailyBreakdown.removingSkillUsageServices(
-                    from: self.store.openAIDashboard?.usageBreakdown ?? []))
+                    from: self.store.openAIDashboard?.usageBreakdown ?? [])))
         case Self.creditsHistoryChartID:
-            Self.dashboardBreakdownReadinessSignature(self.store.openAIDashboard?.dailyBreakdown ?? [])
+            .text(Self.dashboardBreakdownReadinessSignature(self.store.openAIDashboard?.dailyBreakdown ?? []))
         case Self.costHistoryChartID:
-            identity.provider.map(self.costHistoryRenderSignature(for:)) ?? "missing-provider"
+            if let provider = identity.provider {
+                self.costHistoryRenderFingerprint(for: provider)
+            } else {
+                .text("missing-provider")
+            }
         case Self.usageHistoryChartID:
-            identity.provider.map(self.usageHistoryRenderSignature(for:)) ?? "missing-provider"
+            .text(identity.provider.map(self.usageHistoryRenderSignature(for:)) ?? "missing-provider")
         case Self.storageBreakdownID:
-            identity.provider.map(self.storageBreakdownRenderSignature(for:)) ?? "missing-provider"
+            .text(identity.provider.map(self.storageBreakdownRenderSignature(for:)) ?? "missing-provider")
         case Self.statusComponentsID:
-            identity.provider.map(self.statusComponentsRenderSignature(for:)) ?? "missing-provider"
+            .text(identity.provider.map(self.statusComponentsRenderSignature(for:)) ?? "missing-provider")
         case Self.zaiHourlyUsageChartID:
-            identity.provider.map(self.zaiHourlyUsageRenderSignature(for:)) ?? "missing-provider"
+            .text(identity.provider.map(self.zaiHourlyUsageRenderSignature(for:)) ?? "missing-provider")
         default:
-            "unknown"
+            .text("unknown")
         }
-        return [
-            identity.chartID,
-            identity.providerRawValue ?? "",
-            String(Double(width).bitPattern, radix: 16),
-            contentSignature,
-        ].joined(separator: "|")
+        return HostedSubviewRenderSignature(
+            chartID: identity.chartID,
+            providerRawValue: identity.providerRawValue,
+            widthBitPattern: Double(width).bitPattern,
+            content: contentSignature)
     }
 
-    private func costHistoryRenderSignature(for provider: UsageProvider) -> String {
-        guard let snapshot = self.tokenSnapshotForCostHistorySubmenu(provider: provider) else { return "none" }
-        return [
-            snapshot.currencyCode,
-            "\(snapshot.historyDays)",
-            snapshot.historyLabel ?? "",
-            snapshot.last30DaysCostUSD.map { String($0.bitPattern, radix: 16) } ?? "nil",
-            String(reflecting: snapshot.daily),
-            String(reflecting: snapshot.projects),
-        ].joined(separator: "|")
+    private func costHistoryRenderFingerprint(for provider: UsageProvider) -> HostedSubviewContentFingerprint {
+        guard let snapshot = self.tokenSnapshotForCostHistorySubmenu(provider: provider) else {
+            return .text("none")
+        }
+        return .costHistory(CostHistoryChartMenuView.renderFingerprint(from: snapshot))
     }
 
     private func usageHistoryRenderSignature(for provider: UsageProvider) -> String {
@@ -626,3 +648,16 @@ extension StatusItemController {
         return true
     }
 }
+
+#if DEBUG
+extension StatusItemController {
+    func _hostedSubviewRenderSignatureForTesting(menu: NSMenu, width: CGFloat) -> HostedSubviewRenderSignature? {
+        guard let identity = self.hostedSubviewIdentity(for: menu) else { return nil }
+        return self.hostedSubviewRenderSignature(identity: identity, width: width)
+    }
+
+    func _storedHostedSubviewRenderSignatureForTesting(menu: NSMenu) -> HostedSubviewRenderSignature? {
+        self.hostedSubviewRenderSignatures.object(forKey: menu)?.signature
+    }
+}
+#endif

Sources/CodexBar/StatusItemController.swift

@@ -139,7 +139,7 @@ final class StatusItemController: NSObject, NSMenuDelegate, StatusItemControllin
     var menuProviders: [ObjectIdentifier: UsageProvider] = [:]
     var menuSession = MenuSessionCoordinator<ObjectIdentifier>()
     var menuReadinessSignatures: [ObjectIdentifier: String] = [:]
-    let hostedSubviewRenderSignatures = NSMapTable<NSMenu, NSString>.weakToStrongObjects()
+    let hostedSubviewRenderSignatures = NSMapTable<NSMenu, HostedSubviewRenderSignatureBox>.weakToStrongObjects()
     /// Persistent Refresh rows are weakly tracked so their enabled state can change during menu tracking.
     let persistentRefreshItems = NSHashTable<NSMenuItem>.weakObjects()
     var menuCardHeightCache: [MenuCardHeightCacheKey: CGFloat] = [:]