fixes

Author: ndelangen

scripts/create-nx-sandbox-projects.ts

@@ -1,5 +1,5 @@
-import * as fs from 'fs';
-import * as path from 'path';
+import { existsSync, mkdirSync, writeFileSync } from 'node:fs';
+import { dirname, join } from 'node:path';
 
 import * as templates from '../code/lib/cli-storybook/src/sandbox-templates';
 
@@ -31,7 +31,7 @@ const projectJson = (name: string, framework: string, tags: string[]) => ({
 });
 Object.entries(allTemplates).forEach(([key, value]) => {
   const p = key.replaceAll('/', '-');
-  const full = path.join(process.cwd(), '../code/sandbox', p, 'project.json');
+  const full = join(process.cwd(), '../code/sandbox', p, 'project.json');
 
   console.log(full);
   const framework = value.expected.framework.replace('@storybook/', '');
@@ -44,7 +44,7 @@ Object.entries(allTemplates).forEach(([key, value]) => {
   ];
   ensureDirectoryExistence(full);
   console.log(full);
-  fs.writeFileSync(
+  writeFileSync(
     full,
     '// auto-generated from scripts/create-nx-sandbox-projects.ts\n' +
       JSON.stringify(projectJson(key, framework, tags), null, 2),
@@ -55,10 +55,10 @@ Object.entries(allTemplates).forEach(([key, value]) => {
 });
 
 function ensureDirectoryExistence(filePath: string): void {
-  const dirname = path.dirname(filePath);
-  if (fs.existsSync(dirname)) {
+  const dir = dirname(filePath);
+  if (existsSync(dir)) {
     return;
   }
-  ensureDirectoryExistence(dirname);
-  fs.mkdirSync(dirname);
+  ensureDirectoryExistence(dir);
+  mkdirSync(dir);
 }

scripts/release/__tests__/version.test.ts

@@ -280,7 +280,7 @@ describe('Version', () => {
         { spaces: 2 }
       );
       expect(execaCommand).toHaveBeenCalledWith('yarn install --mode=update-lockfile', {
-        cwd: path.join(CODE_DIR_PATH),
+        cwd: join(CODE_DIR_PATH),
         cleanup: true,
         stdio: undefined,
       });