final cleanup

Author: yannbf

code/.eslintrc.js

@@ -208,6 +208,7 @@ module.exports = {
     },
     {
       files: ['**/*.ts', '!**/*.test.*', '!**/*.spec.*'],
+      excludedFiles: ['**/*.test.*', '**/*.mockdata.*'],
       rules: {
         'local-rules/no-uncategorized-errors': 'warn',
       },

code/.yarnrc.yml

@@ -2,6 +2,12 @@ compressionLevel: 0
 
 enableGlobalCache: true
 
+logFilters:
+  - code: YN0005
+    level: discard
+  - code: YN0076
+    level: discard
+
 nodeLinker: node-modules
 
 npmRegistryServer: 'https://registry.yarnpkg.com'

code/addons/a11y/src/components/A11YPanel.test.tsx

@@ -100,6 +100,17 @@ describe('A11YPanel', () => {
     expect(getByText(/Initializing/)).toBeTruthy();
   });
 
+  it('should set running status on event', async () => {
+    const { getByText } = render(<ThemedA11YPanel />);
+    const useChannelArgs = mockedApi.useChannel.mock.calls[0][0];
+    act(() => useChannelArgs[EVENTS.RUNNING]());
+    await waitFor(() => {
+      expect(getByText(/Please wait while the accessibility scan is running/)).toBeTruthy();
+    });
+  });
+
+  // TODO: The tests below are skipped because of unknown issues with ThemeProvider
+  // which cause errors like TypeError: Cannot read properties of undefined (reading 'defaultText')
   it.skip('should handle "manual" status', async () => {
     mockedApi.useParameter.mockReturnValue({ manual: true });
     const { getByText } = render(<ThemedA11YPanel />);
@@ -123,15 +134,6 @@ describe('A11YPanel', () => {
     });
   });
 
-  it('should set running status on event', async () => {
-    const { getByText } = render(<ThemedA11YPanel />);
-    const useChannelArgs = mockedApi.useChannel.mock.calls[0][0];
-    act(() => useChannelArgs[EVENTS.RUNNING]());
-    await waitFor(() => {
-      expect(getByText(/Please wait while the accessibility scan is running/)).toBeTruthy();
-    });
-  });
-
   it.skip('should handle "ran" status', async () => {
     const { getByText } = render(<ThemedA11YPanel />);
     const useChannelArgs = mockedApi.useChannel.mock.calls[0][0];

code/addons/a11y/src/components/VisionSimulator.test.tsx

@@ -25,6 +25,8 @@ function ThemedVisionSimulator() {
 }
 
 describe('Vision Simulator', () => {
+  // TODO: there are issues with the ThemeProvider from lib/theming for some reason
+  // which are causing rendering issues in the component for all these tests
   it.skip('should render tool button', async () => {
     // when
     render(<ThemedVisionSimulator />);

code/addons/a11y/src/manager.test.tsx

@@ -36,7 +36,7 @@ describe('A11yManager', () => {
     mockedApi.useAddonState.mockImplementation(() => [undefined]);
     registrationImpl(api as unknown as api.API);
     const title = mockedAddons.add.mock.calls.map(([_, def]) => def).find(isPanel)
-      ?.title as Function;
+      ?.title as () => void;
 
     // when / then
     expect(title()).toMatchInlineSnapshot(`
@@ -70,7 +70,7 @@ describe('A11yManager', () => {
     ]);
     registrationImpl(mockedApi);
     const title = mockedAddons.add.mock.calls.map(([_, def]) => def).find(isPanel)
-      ?.title as Function;
+      ?.title as () => void;
 
     // when / then
     expect(title()).toMatchInlineSnapshot(`

code/addons/jest/src/shared.test.ts

@@ -1,33 +1,33 @@
-import { describe, expect, test } from 'vitest';
+import { describe, expect, it } from 'vitest';
 import { defineJestParameter } from './shared';
 
 describe('defineJestParameter', () => {
-  test('infers from story file name if jest parameter is not provided', () => {
+  it('infers from story file name if jest parameter is not provided', () => {
     expect(defineJestParameter({ fileName: './stories/addon-jest.stories.js' })).toEqual([
       'addon-jest',
     ]);
   });
 
-  test('wraps string jest parameter with an array', () => {
+  it('wraps string jest parameter with an array', () => {
     expect(defineJestParameter({ jest: 'addon-jest' })).toEqual(['addon-jest']);
   });
 
-  test('returns as is if jest parameter is an array', () => {
+  it('returns as is if jest parameter is an array', () => {
     expect(defineJestParameter({ jest: ['addon-jest', 'something-else'] })).toEqual([
       'addon-jest',
       'something-else',
     ]);
   });
 
-  test('returns null if disabled option is passed to jest parameter', () => {
+  it('returns null if disabled option is passed to jest parameter', () => {
     expect(defineJestParameter({ jest: { disabled: true } })).toBeNull();
   });
 
-  test('returns null if no filename to infer from', () => {
+  it('returns null if no filename to infer from', () => {
     expect(defineJestParameter({})).toBeNull();
   });
 
-  test('returns null if filename is a module ID that cannot be inferred from', () => {
+  it('returns null if filename is a module ID that cannot be inferred from', () => {
     // @ts-expect-error Storybook's fileName type is string, but according to this test it could be number in case it is a module id.
     expect(defineJestParameter({ fileName: 1234 })).toBeNull();
   });

code/builders/builder-manager/src/utils/files.test.ts

@@ -1,12 +1,12 @@
-import { test, expect } from 'vitest';
+import { it, expect } from 'vitest';
 import type { OutputFile } from 'esbuild';
 import { platform } from 'os';
 import { sanitizePath } from './files';
 
 const os = platform();
 const isWindows = os === 'win32';
 
-test('sanitizePath', () => {
+it('sanitizePath', () => {
   const addonsDir = isWindows
     ? 'C:\\Users\\username\\Projects\\projectname\\storybook'
     : '/Users/username/Projects/projectname/storybook';

code/builders/builder-vite/src/plugins/external-globals-plugin.test.ts

@@ -1,4 +1,4 @@
-import { test, expect } from 'vitest';
+import { it, expect } from 'vitest';
 import { rewriteImport } from './external-globals-plugin';
 
 const packageName = '@storybook/package';
@@ -37,7 +37,7 @@ const cases = [
   },
 ];
 
-test('rewriteImport', () => {
+it('rewriteImport', () => {
   cases.forEach(({ input, output, globals: caseGlobals, packageName: casePackage }) => {
     expect(rewriteImport(input, caseGlobals, casePackage)).toStrictEqual(output);
   });

code/deprecated/channel-websocket/vitest.config.ts

@@ -116,8 +116,15 @@ describe('Channel', () => {
     });
 
     it('should use setImmediate if async is true', () => {
+      // @ts-expect-error no idea what's going on here!
+      global.setImmediate = vi.fn(setImmediate);
+
       channel = new Channel({ async: true, transport });
       channel.addListener('event1', vi.fn());
+
+      channel.emit('event1', 'test-data');
+
+      expect(setImmediate).toHaveBeenCalled();
     });
   });