Skip to content

Commit 7f0b353

Browse files
authored
Merge pull request #33872 from storybookjs/yann/readd-traces-to-e2e
Build: Fix missing traces in E2E step
2 parents c84a207 + 0dd4756 commit 7f0b353

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

code/playwright.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export default defineConfig({
4747
// baseURL: 'http://localhost:3000',
4848

4949
/* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
50-
trace: 'on-first-retry',
50+
trace: 'retain-on-failure',
5151
},
5252

5353
/* Configure projects for major browsers */

scripts/ci/sandboxes.ts

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,10 @@ function defineSandboxJob_dev({
9797
},
9898
},
9999
artifact.persist(join(LINUX_ROOT_DIR, WORKING_DIR, 'test-results'), 'test-results'),
100+
artifact.persist(
101+
join(LINUX_ROOT_DIR, WORKING_DIR, 'code', 'playwright-results'),
102+
'playwright-results'
103+
),
100104
testResults.persist(join(LINUX_ROOT_DIR, WORKING_DIR, 'test-results')),
101105
]
102106
: [
@@ -289,6 +293,10 @@ export function defineSandboxFlow<Key extends string>(key: Key) {
289293
},
290294
},
291295
artifact.persist(join(LINUX_ROOT_DIR, WORKING_DIR, 'test-results'), 'test-results'),
296+
artifact.persist(
297+
join(LINUX_ROOT_DIR, WORKING_DIR, 'code', 'playwright-results'),
298+
'playwright-results'
299+
),
292300
testResults.persist(join(LINUX_ROOT_DIR, WORKING_DIR, 'test-results')),
293301
],
294302
}),

0 commit comments

Comments
 (0)