CLI: Fix "Invalid version null" issues by improved version detection

[valentinpalkovic]

Closes #22345

What I did

• Removed bower support
• Implemented methods to read the version of an installed package
• Fixed some places, which weren't pnpm sensitive
• Removed Angular 12 automigrations
• Fixed upgrade and automigrate commands in nx projects
• Fixed setting eslint-plugin in eslintPlugin automigrate
• Fixed Storybook upgrade/init commands in yarn workspace environments
• Fixed a bug where nextjs wasn't working properly in pnp environments
• Fixed detection of pnp in workspaces when Storybook init was called in a subdirectory
• Fixed @storybook/addon-docs not automatically installed when compodoc was in use

Checklist

• Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
• Make sure to add/update documentation regarding your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Maintainers

• If this PR should be tested against many or all sandboxes,
  make sure to add the ci:merged or ci:daily GH label to it.
• Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue	Package	Version	Note	Source
Network access	@yarnpkg/libzip	2.3.0	Module: globalThis["fetch"] Location: lib/libzipAsync.js	code/lib/cli/package.json via @yarnpkg/fslib@2.10.3

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that isn't functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore @yarnpkg/libzip@2.3.0

[ndelangen]

Can this be merged @valentinpalkovic ?

[yannbf]

Can this be merged @valentinpalkovic ?

No, I'm working on it!

[yannbf]

Let me start by saying that this is super awesome ❤️

Unfortunately it seems like the pnp solutions do not work?

Yarn2

• Detecting project typeError while fetching package version in Yarn PnP mode: Error: Your application tried to access nx, but it isn't declared in your dependencies; this makes the require call ambiguous and unsound.

Required package: nx
Required by: /Users/yannbraga/experiments/delete/react-ts

    at makeError (/Users/yannbraga/experiments/delete/react-ts/.pnp.cjs:21064:34)
    at resolveToUnqualified (/Users/yannbraga/experiments/delete/react-ts/.pnp.cjs:22781:21)
    at Object.resolveToUnqualified (/Users/yannbraga/experiments/delete/react-ts/.pnp.cjs:22973:26)
    at Yarn2Proxy.getPackageVersion (/Users/yannbraga/open-source/storybook/code/lib/cli/dist/generate.js:1751:43)
    at isNxProject (/Users/yannbraga/open-source/storybook/code/lib/cli/dist/generate.js:535:42)

And similar errors happen when trying to resolve prettier, @babel/plugin-transform-typescript, eslint-plugin-storybook in the same execution

PNPM

Detecting project typeError while fetching package version in Yarn PnP mode: Error: Your application tried to access nx, but it isn't declared in your dependencies; this makes the require call ambiguous and unsound.

Required package: nx (via "nx")
Required by: /Users/yannbraga/experiments/delete/react-ts

    at internalTools_makeError (/Users/yannbraga/experiments/delete/react-ts/.pnp.cjs:13925:34)
    at resolveToUnqualified (/Users/yannbraga/experiments/delete/react-ts/.pnp.cjs:14884:23)
    at Object.resolveToUnqualified (/Users/yannbraga/experiments/delete/react-ts/.pnp.cjs:15051:26)
    at PNPMProxy.getPackageVersion (/Users/yannbraga/open-source/storybook/code/lib/cli/dist/generate.js:1492:43)
    at isNxProject (/Users/yannbraga/open-source/storybook/code/lib/cli/dist/generate.js:535:42)
    at detect (/Users/yannbraga/open-source/storybook/code/lib/cli/dist/generate.js:673:13)

It also feels a little weird having tons of errors but the storybook init command continues “normally” as these errors are console.error messages

Can you take a look at that?

[socket-security]

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages		Version	New capabilities	Transitives1	Size	Publisher
@yarnpkg/libzip	🆕	2.3.0	network, filesystem	+1	785 kB	arcanis
@yarnpkg/fslib	🆕	2.10.3	filesystem	+2	1.06 MB	arcanis

Footnotes

1. https://docs.socket.dev ↩

[yannbf]

Unfortunately there is something going on where the output of automigration affects the other and the user gets stuck. I have to investigate what's causing it.

[yannbf]

Time to merge this!!