Core: Disable esbuild on files imported from node_modules#23018
Merged
Conversation
node_modules.node_modules
shilman
reviewed
Jun 10, 2023
Member
shilman
left a comment
There was a problem hiding this comment.
This looks OK to me, but tbh I really don't understand the implications. I guess this will have problems with ESM-only packages until node supports ESM out of the box?
Member
|
Node does support ESM out of the box starting node16 (which is the minimum for storybook already), as long as you import ESM with an imperative import. You can't require an ESM. |
ndelangen
approved these changes
Jun 12, 2023
shilman
approved these changes
Jun 13, 2023
Member
shilman
left a comment
There was a problem hiding this comment.
If we need to, we can add this as a config option to main.js later
24 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
esbuildover some of our larger imports (e.g.typescript, imported byreact-docgen-typescript-plugin) can significantly increase their import time (not totally clear why as they are JS files).I'm not sure why we changed this setting from the default (to not run
esbuildovernode_modules) in the first place.What I did
Switched back to the default -- to leave files from
node_modulesuntranspiled.How to test
Hopefully should be covered by the daily sandboxes. But it would be very interesting to see how this affects our measured timings.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]